From 95dfa5223ac6c680f2138255d8b7ab122a3fd86d Mon Sep 17 00:00:00 2001 From: Zach Stein Date: Thu, 25 Oct 2018 13:48:58 -0700 Subject: [PATCH] Clarify the desired semantics of AsyncResolverInterface::GetResolvedAddress. Bug: webrtc:9861 Change-Id: I4b0bf0619a5e2b04765a727a183584dcf0a4cf41 Reviewed-on: https://webrtc-review.googlesource.com/c/106142 Reviewed-by: Qingsi Wang Commit-Queue: Zach Stein Cr-Commit-Position: refs/heads/master@{#25380} --- rtc_base/asyncresolverinterface.h | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/rtc_base/asyncresolverinterface.h b/rtc_base/asyncresolverinterface.h index 5b2303f4d8..f3df884249 100644 --- a/rtc_base/asyncresolverinterface.h +++ b/rtc_base/asyncresolverinterface.h @@ -22,9 +22,12 @@ class AsyncResolverInterface { AsyncResolverInterface(); virtual ~AsyncResolverInterface(); - // Start address resolve process. + // Start address resolution of the hostname in |addr|. virtual void Start(const SocketAddress& addr) = 0; - // Returns top most resolved address of |family| + // Returns true iff the address from |Start| was successfully resolved. + // If the address was successfully resolved, sets |addr| to a copy of the + // address from |Start| with the IP address set to the top most resolved + // address of |family| (|addr| will have both hostname and the resolved ip). virtual bool GetResolvedAddress(int family, SocketAddress* addr) const = 0; // Returns error from resolver. virtual int GetError() const = 0;