From 955d0eed2f3a27bfa832ea60020ee256b946b885 Mon Sep 17 00:00:00 2001 From: "punyabrata@webrtc.org" Date: Fri, 9 Sep 2011 16:28:51 +0000 Subject: [PATCH] Removing echo warning because it seems to be flooding the logs anytime there is any echo. Secondly, this should be treated as a warning in the sense that echo in the signal does not mean something is wrong with the engine.f Review URL: http://webrtc-codereview.appspot.com/139018 git-svn-id: http://webrtc.googlecode.com/svn/trunk@572 4adac7df-926f-26a2-2b94-8c16560cd09d --- src/voice_engine/main/source/transmit_mixer.cc | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/src/voice_engine/main/source/transmit_mixer.cc b/src/voice_engine/main/source/transmit_mixer.cc index 570baa53ba..f4ccf5f230 100644 --- a/src/voice_engine/main/source/transmit_mixer.cc +++ b/src/voice_engine/main/source/transmit_mixer.cc @@ -1296,7 +1296,7 @@ WebRtc_Word32 TransmitMixer::APMProcessStream( captureLevel) == -1) { WEBRTC_TRACE(kTraceWarning, kTraceVoice, VoEId(_instanceId, -1), - "AudioProcessingModule::set_stream_analog_level" + "AudioProcessingModule::set_stream_analog_level " "(captureLevel=%u,) => error", captureLevel); } @@ -1341,7 +1341,7 @@ WebRtc_Word32 TransmitMixer::APMProcessStream( } else { WEBRTC_TRACE(kTraceWarning, kTraceVoice, VoEId(_instanceId, -1), - "TransmitMixer::APMProcessStream() failed to" + "TransmitMixer::APMProcessStream() failed to " "retrieve level metrics"); _audioLevel_dBov = 100; } @@ -1353,21 +1353,15 @@ WebRtc_Word32 TransmitMixer::APMProcessStream( if (_saturationWarning == 1) { WEBRTC_TRACE(kTraceWarning, kTraceVoice, VoEId(_instanceId, -1), - "TransmitMixer::APMProcessStream() pending" + "TransmitMixer::APMProcessStream() pending " "saturation warning exists"); } _saturationWarning = 1; // triggers callback from moduleprocess thread WEBRTC_TRACE(kTraceWarning, kTraceVoice, VoEId(_instanceId, -1), - "TransmitMixer::APMProcessStream() VE_SATURATION_WARNING" + "TransmitMixer::APMProcessStream() VE_SATURATION_WARNING " "message has been posted for callback"); } - if (_audioProcessingModulePtr->echo_cancellation()->stream_has_echo()) - { - WEBRTC_TRACE(kTraceWarning, kTraceVoice, VoEId(_instanceId, -1), - "AudioProcessingModule notification: Echo"); - } - return 0; }