admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Removed implicit divisions in the residual echo detector

Browse Source 
This CL changes the updating of a loop index from using the modulus
operator to using a conditional, avoiding the divisions done in the
modulus operator which had a measurable impact on mpbile
platforms.

Additionally, there is a similar removal of another modulus operator, but the impact of that should be negligible.

BUG=webrtc:7666

Review-Url: https://codereview.webrtc.org/2882183004
Cr-Commit-Position: refs/heads/master@{#18168}
This commit is contained in:
peah 2017-05-16 07:25:06 -07:00 committed by Commit bot
parent e3fc11464e
commit 94f6fa0526
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
webrtc/modules/audio_processing/residual_echo_detector.cc
View File

@ -113,9 +113,8 @@ void ResidualEchoDetector::AnalyzeCaptureAudio(
// Update the covariance values and determine the new echo likelihood.
echo_likelihood_ = 0.f;
size_t read_index = next_insertion_index_;
for (size_t delay = 0; delay < covariances_.size(); ++delay) {
const size_t read_index =
(kLookbackFrames + next_insertion_index_ - delay) % kLookbackFrames;
RTC_DCHECK_LT(read_index, render_power_.size());
covariances_[delay].Update(capture_power, capture_mean,
capture_std_deviation, render_power_[read_index],
@ -123,6 +122,8 @@ void ResidualEchoDetector::AnalyzeCaptureAudio(
render_power_std_dev_[read_index]);
echo_likelihood_ = std::max(
echo_likelihood_, covariances_[delay].normalized_cross_correlation());
read_index = read_index > 0 ? read_index - 1 : kLookbackFrames - 1;
}
RTC_DCHECK_LT(echo_likelihood_, 1.1f);
reliability_ = (1.0f - kAlpha) * reliability_ + kAlpha * 1.0f;
@ -138,8 +139,9 @@ void ResidualEchoDetector::AnalyzeCaptureAudio(
recent_likelihood_max_.Update(echo_likelihood_);
// Update the next insertion index.
++next_insertion_index_;
next_insertion_index_ %= kLookbackFrames;
next_insertion_index_ = next_insertion_index_ < (kLookbackFrames - 1)
? next_insertion_index_ + 1
: 0;
}
void ResidualEchoDetector::Initialize() {