From 94ef424b3160262f0f8298b8abd47c29bb9ee3da Mon Sep 17 00:00:00 2001
From: Mirko Bonadei <mbonadei@webrtc.org>
Date: Fri, 20 Jul 2018 13:33:06 +0200
Subject: [PATCH] Enable clang::find_bad_constructs for
 examples/androidnativeapi.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

This CL removes //build/config/clang:find_bad_constructs from the
suppressed_configs list, which means that clang:find_bad_constructs
is now enabled on these translation units.

Bug: webrtc:9251, webrtc:163
Change-Id: I9f3c3ce78aa82cbf68f34999b0a7fa9507fe5154
Reviewed-on: https://webrtc-review.googlesource.com/89741
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24059}
---
 examples/androidnativeapi/BUILD.gn                 | 5 -----
 examples/androidnativeapi/jni/androidcallclient.cc | 2 ++
 examples/androidnativeapi/jni/androidcallclient.h  | 1 +
 3 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/examples/androidnativeapi/BUILD.gn b/examples/androidnativeapi/BUILD.gn
index 7be09b7bc1..6a6209d9a3 100644
--- a/examples/androidnativeapi/BUILD.gn
+++ b/examples/androidnativeapi/BUILD.gn
@@ -43,11 +43,6 @@ rtc_shared_library("examples_androidnativeapi_jni") {
   suppressed_configs += [ "//build/config/android:hide_all_but_jni_onload" ]
   configs += [ "//build/config/android:hide_all_but_jni" ]
 
-  if (is_clang) {
-    # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
-    suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
-  }
-
   deps = [
     ":generated_jni",
     "//api:libjingle_peerconnection_api",
diff --git a/examples/androidnativeapi/jni/androidcallclient.cc b/examples/androidnativeapi/jni/androidcallclient.cc
index 3b196294cf..005f369a6d 100644
--- a/examples/androidnativeapi/jni/androidcallclient.cc
+++ b/examples/androidnativeapi/jni/androidcallclient.cc
@@ -80,6 +80,8 @@ AndroidCallClient::AndroidCallClient()
   CreatePeerConnectionFactory();
 }
 
+AndroidCallClient::~AndroidCallClient() = default;
+
 void AndroidCallClient::Call(JNIEnv* env,
                              const webrtc::JavaRef<jobject>& cls,
                              const webrtc::JavaRef<jobject>& local_sink,
diff --git a/examples/androidnativeapi/jni/androidcallclient.h b/examples/androidnativeapi/jni/androidcallclient.h
index a0507e3f7f..d456e9c10a 100644
--- a/examples/androidnativeapi/jni/androidcallclient.h
+++ b/examples/androidnativeapi/jni/androidcallclient.h
@@ -28,6 +28,7 @@ namespace webrtc_examples {
 class AndroidCallClient {
  public:
   AndroidCallClient();
+  ~AndroidCallClient();
 
   void Call(JNIEnv* env,
             const webrtc::JavaRef<jobject>& cls,