From 94349552de348e9d87a099600d211a75291ef96d Mon Sep 17 00:00:00 2001 From: "wu@webrtc.org" Date: Fri, 2 Aug 2013 23:30:50 +0000 Subject: [PATCH] Disable P2PTransportChannelTest.* on memcheck and tsan bots due to issue 1972. TBR=mallinath BUG=1972 RISK=P3 TEST=with below cmd lines and disabled tests won't run tools/valgrind-webrtc/webrtc_tests.sh --build_dir out/Debug --test libjingle_p2p_unittest --gtest_filter=P2PTransportChannelTest* --tool tsan tools/valgrind-webrtc/webrtc_tests.sh --build_dir out/Debug --test libjingle_p2p_unittest --gtest_filter=P2PTransportChannelTest* --tool memcheck Review URL: https://webrtc-codereview.appspot.com/1954004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@4479 4adac7df-926f-26a2-2b94-8c16560cd09d --- .../libjingle_p2p_unittest.gtest-memcheck.txt | 10 ++-------- .../libjingle_p2p_unittest.gtest-tsan.txt | 3 ++- 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/tools/valgrind-webrtc/gtest_exclude/libjingle_p2p_unittest.gtest-memcheck.txt b/tools/valgrind-webrtc/gtest_exclude/libjingle_p2p_unittest.gtest-memcheck.txt index d195a513f7..97894d2d49 100644 --- a/tools/valgrind-webrtc/gtest_exclude/libjingle_p2p_unittest.gtest-memcheck.txt +++ b/tools/valgrind-webrtc/gtest_exclude/libjingle_p2p_unittest.gtest-memcheck.txt @@ -1,10 +1,4 @@ -# Fails when run under memcheck -# https://code.google.com/p/webrtc/issues/detail?id=1972 -P2PTransportChannelTest.TestBLOCK_UDPToOPENAsIce -P2PTransportChannelTest.TestOPENToBLOCK_UDPAsIce -P2PTransportChannelTest.TestOPENToNAT_FULL_CONEAsGiceNoneSharedUfrag -P2PTransportChannelTest.TestOPENToNAT_FULL_CONEAsGiceP0SharedUfrag -P2PTransportChannelTest.TestOPENToNAT_FULL_CONEAsGiceP1SharedUfrag -P2PTransportChannelTest.TestOPENToNAT_PORT_RESTRICTEDAsIce +# TODO(wu): Reenable P2PTransportChannelTest after issue 2158 is resolved. +P2PTransportChannelTest.* PortTest.TestSendStunMessageAsIce diff --git a/tools/valgrind-webrtc/gtest_exclude/libjingle_p2p_unittest.gtest-tsan.txt b/tools/valgrind-webrtc/gtest_exclude/libjingle_p2p_unittest.gtest-tsan.txt index ffbcd4a91f..5fe699e616 100644 --- a/tools/valgrind-webrtc/gtest_exclude/libjingle_p2p_unittest.gtest-tsan.txt +++ b/tools/valgrind-webrtc/gtest_exclude/libjingle_p2p_unittest.gtest-tsan.txt @@ -1,2 +1,3 @@ -P2PTransportChannelTest.TestOPENToNAT_FULL_CONEAsGiceNoneSharedUfrag +# TODO(wu): Reenable P2PTransportChannelTest after issue 2158 is resolved. +P2PTransportChannelTest.* PortTest.TestSendStunMessageAsIce