From 940c2b500589d1c0cd54cd927e3b369856ec1a1e Mon Sep 17 00:00:00 2001 From: Gustaf Ullberg Date: Thu, 8 Aug 2019 15:04:41 +0200 Subject: [PATCH] AEC3: Reduce level of log messages MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This change reduces the level of several non-critical log messages in order to reduce log spamming. Bug: webrtc:8671 Change-Id: I6faae7a2ae4eeafd18c2770208485a75ad946e20 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/148528 Reviewed-by: Per Åhgren Commit-Queue: Gustaf Ullberg Cr-Commit-Position: refs/heads/master@{#28809} --- .../audio_processing/aec3/block_processor.cc | 4 ++-- modules/audio_processing/aec3/echo_remover.cc | 3 +-- .../aec3/render_delay_buffer.cc | 22 +++++++++---------- 3 files changed, 14 insertions(+), 15 deletions(-) diff --git a/modules/audio_processing/aec3/block_processor.cc b/modules/audio_processing/aec3/block_processor.cc index 0c31a2ec8d..49a9cfd6e3 100644 --- a/modules/audio_processing/aec3/block_processor.cc +++ b/modules/audio_processing/aec3/block_processor.cc @@ -167,8 +167,8 @@ void BlockProcessorImpl::ProcessCapture( bool delay_change = render_buffer_->AlignFromDelay(estimated_delay_->delay); if (delay_change) { - RTC_LOG(LS_WARNING) << "Delay changed to " << estimated_delay_->delay - << " at block " << capture_call_counter_; + RTC_LOG(LS_INFO) << "Delay changed to " << estimated_delay_->delay + << " at block " << capture_call_counter_; echo_path_variability.delay_change = EchoPathVariability::DelayAdjustment::kNewDetectedDelay; } diff --git a/modules/audio_processing/aec3/echo_remover.cc b/modules/audio_processing/aec3/echo_remover.cc index f93288c9d9..c7e7f7cd5e 100644 --- a/modules/audio_processing/aec3/echo_remover.cc +++ b/modules/audio_processing/aec3/echo_remover.cc @@ -205,8 +205,7 @@ void EchoRemoverImpl::ProcessCapture( if (gain_change_hangover_ == 0) { constexpr int kMaxBlocksPerFrame = 3; gain_change_hangover_ = kMaxBlocksPerFrame; - RTC_LOG(LS_WARNING) - << "Gain change detected at block " << block_counter_; + RTC_LOG(LS_INFO) << "Gain change detected at block " << block_counter_; } else { echo_path_variability.gain_change = false; } diff --git a/modules/audio_processing/aec3/render_delay_buffer.cc b/modules/audio_processing/aec3/render_delay_buffer.cc index 1a48f158f8..92f2f65fe2 100644 --- a/modules/audio_processing/aec3/render_delay_buffer.cc +++ b/modules/audio_processing/aec3/render_delay_buffer.cc @@ -192,7 +192,7 @@ RenderDelayBuffer::BufferingEvent RenderDelayBufferImpl::Insert( } else { if (++num_api_calls_in_a_row_ > max_observed_jitter_) { max_observed_jitter_ = num_api_calls_in_a_row_; - RTC_LOG(LS_WARNING) + RTC_LOG(LS_INFO) << "New max number api jitter observed at render block " << render_call_counter_ << ": " << num_api_calls_in_a_row_ << " blocks"; @@ -238,7 +238,7 @@ RenderDelayBufferImpl::PrepareCaptureProcessing() { } else { if (++num_api_calls_in_a_row_ > max_observed_jitter_) { max_observed_jitter_ = num_api_calls_in_a_row_; - RTC_LOG(LS_WARNING) + RTC_LOG(LS_INFO) << "New max number api jitter observed at capture block " << capture_call_counter_ << ": " << num_api_calls_in_a_row_ << " blocks"; @@ -249,15 +249,15 @@ RenderDelayBufferImpl::PrepareCaptureProcessing() { if (DetectExcessRenderBlocks()) { // Too many render blocks compared to capture blocks. Risk of delay ending // up before the filter used by the delay estimator. - RTC_LOG(LS_WARNING) << "Excess render blocks detected at block " - << capture_call_counter_; + RTC_LOG(LS_INFO) << "Excess render blocks detected at block " + << capture_call_counter_; Reset(); event = BufferingEvent::kRenderOverrun; } else if (RenderUnderrun()) { // Don't increment the read indices of the low rate buffer if there is a // render underrun. - RTC_LOG(LS_WARNING) << "Render buffer underrun detected at block " - << capture_call_counter_; + RTC_LOG(LS_INFO) << "Render buffer underrun detected at block " + << capture_call_counter_; IncrementReadIndices(); // Incrementing the buffer index without increasing the low rate buffer // index means that the delay is reduced by one. @@ -286,9 +286,9 @@ bool RenderDelayBufferImpl::AlignFromDelay(size_t delay) { if (!external_audio_buffer_delay_verified_after_reset_ && external_audio_buffer_delay_ && delay_) { int difference = static_cast(delay) - static_cast(*delay_); - RTC_LOG(LS_WARNING) << "Mismatch between first estimated delay after reset " - "and externally reported audio buffer delay: " - << difference << " blocks"; + RTC_LOG(LS_INFO) << "Mismatch between first estimated delay after reset " + "and externally reported audio buffer delay: " + << difference << " blocks"; external_audio_buffer_delay_verified_after_reset_ = true; } if (delay_ && *delay_ == delay) { @@ -308,7 +308,7 @@ bool RenderDelayBufferImpl::AlignFromDelay(size_t delay) { void RenderDelayBufferImpl::SetAudioBufferDelay(size_t delay_ms) { if (!external_audio_buffer_delay_) { - RTC_LOG(LS_WARNING) + RTC_LOG(LS_INFO) << "Receiving a first externally reported audio buffer delay of " << delay_ms << " ms."; } @@ -340,7 +340,7 @@ int RenderDelayBufferImpl::ComputeDelay() const { // Set the read indices according to the delay. void RenderDelayBufferImpl::ApplyTotalDelay(int delay) { - RTC_LOG(LS_WARNING) << "Applying total delay of " << delay << " blocks."; + RTC_LOG(LS_INFO) << "Applying total delay of " << delay << " blocks."; blocks_.read = blocks_.OffsetIndex(blocks_.write, -delay); spectra_.read = spectra_.OffsetIndex(spectra_.write, delay); ffts_.read = ffts_.OffsetIndex(ffts_.write, delay);