From 91e3ebe46843a507461cdf457d284a02118eeb4e Mon Sep 17 00:00:00 2001 From: Mirko Bonadei Date: Fri, 25 Oct 2019 17:54:17 +0000 Subject: [PATCH] Revert "Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true."" This reverts commit 29db239fed94bbe40dfddefa9f02409b951efc18. Reason for revert: The test is on its way on https://chromium-review.googlesource.com/c/chromium/src/+/1874722. Original change's description: > Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true." > > This is a reland of 03bc15c646d5b41d3169f2686316944788f640ed > > Original change's description: > > Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true. > > > > In order to land the component build support in Chromium, it is > > easier to turn on symbols export every time that is_component_build=true > > instead of setting rtc_enable_symbol_export=is_component_build in > > Chromium (since is_component_build is not available in .gn). > > > > rtc_enable_symbol_export is still kept in the mix in order to turn > > on symbol exports in any case a shared library will be added to the > > WebRTC build. > > > > Bug: webrtc:9419 > > Change-Id: I5a7195826dea13d9a6f10a1160c35f2864bfa6c2 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157108 > > Reviewed-by: Karl Wiberg > > Commit-Queue: Mirko Bonadei > > Cr-Commit-Position: refs/heads/master@{#29540} > > TBR: kwiberg@webrtc.org > Bug: webrtc:9419 > Change-Id: I6a184290f3f1a60c1ed6cbc86aafe3e7df248ce1 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/158327 > Reviewed-by: Mirko Bonadei > Commit-Queue: Mirko Bonadei > Cr-Commit-Position: refs/heads/master@{#29618} TBR=mbonadei@webrtc.org,kwiberg@webrtc.org Change-Id: Ie3bac3393d6ce0f147f3d79d08d20cc9798b464a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:9419 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/158328 Reviewed-by: Mirko Bonadei Commit-Queue: Mirko Bonadei Cr-Commit-Position: refs/heads/master@{#29619} --- BUILD.gn | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BUILD.gn b/BUILD.gn index 7f0635e737..5cef1303b2 100644 --- a/BUILD.gn +++ b/BUILD.gn @@ -111,7 +111,7 @@ config("common_inherited_config") { cflags = [] ldflags = [] - if (rtc_enable_symbol_export || is_component_build) { + if (rtc_enable_symbol_export) { defines = [ "WEBRTC_ENABLE_SYMBOL_EXPORT" ] }