admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Test creating two senders with the same track.

Browse Source 
When https://crbug.com/webrtc/8734 is resolved this setup should be
valid and CreateOffer() and SetLocalDescription() should work, but
currently it doesn't. It probably fails because both senders are
assigned the same ID (the track ID).

EXPECT-ing the current behavior with a TODO referencing the bug.

Bug: webrtc:8734
Change-Id: If2a9cc9b0be12c39def83b0e219e1ca82dbd7d65
Reviewed-on: https://webrtc-review.googlesource.com/39041
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21654}
This commit is contained in:
Henrik Boström 2018-01-11 17:43:30 +01:00 committed by Commit Bot
parent 1880c7162b
commit 91d039b37f
1 changed files with 23 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
pc/peerconnection_rtp_unittest.cc
View File

@ -866,4 +866,27 @@ TEST_F(PeerConnectionRtpUnifiedPlanTest,
EXPECT_FALSE(caller->observer()->negotiation_needed());
}
// Sender setups in a call.
class PeerConnectionSenderTest : public PeerConnectionRtpTest {};
TEST_F(PeerConnectionSenderTest, CreateTwoSendersWithSameTrack) {
auto caller = CreatePeerConnection();
auto callee = CreatePeerConnection();
auto track = caller->CreateAudioTrack("audio_track");
auto sender1 = caller->AddTrack(track);
ASSERT_TRUE(sender1);
// We need to temporarily reset the track for the subsequent AddTrack() to
// succeed.
EXPECT_TRUE(sender1->SetTrack(nullptr));
auto sender2 = caller->AddTrack(track);
EXPECT_TRUE(sender2);
EXPECT_TRUE(sender1->SetTrack(track));
// TODO(hbos): When https://crbug.com/webrtc/8734 is resolved, this should
// return true, and doing |callee->SetRemoteDescription()| should work.
EXPECT_FALSE(caller->CreateOfferAndSetAsLocal());
}
} // namespace webrtc