admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Disable OpenSSL tests needing a fake clock when boringssl is not used

Browse Source 
since OpenSSL lacks that feature so broke as a result of
https://chromiumdash.appspot.com/commit/130bdcea7e69368cae66e10a99c5e86dc4e5770a

BUG=webrtc:375552698

Change-Id: I55da67a7dcf5815f7190bd43847a9ad6f7c1b93d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/374600
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Philipp Hancke <phancke@meta.com>
Reviewed-by: Jeremy Leconte <jleconte@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#43767}
This commit is contained in:
Philipp Hancke 2025-01-16 17:05:59 -08:00 committed by WebRTC LUCI CQ
parent e6890adc3a
commit 9165a9b436
1 changed files with 18 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
rtc_base/ssl_stream_adapter_unittest.cc
View File

@ -1196,16 +1196,32 @@ class SSLStreamAdapterTestDTLS : public SSLStreamAdapterTestDTLSBase {
std::make_pair(rtc::DIGEST_SHA_256, SHA256_DIGEST_LENGTH)) {} std::make_pair(rtc::DIGEST_SHA_256, SHA256_DIGEST_LENGTH)) {}
}; };
#ifdef OPENSSL_IS_BORINGSSL
#define MAYBE_TestDTLSConnectWithLostFirstPacketNoDelay \
TestDTLSConnectWithLostFirstPacketNoDelay
#else
#define MAYBE_TestDTLSConnectWithLostFirstPacketNoDelay \
DISABLED_TestDTLSConnectWithLostFirstPacketNoDelay
#endif
// Test that we can make a handshake work if the first packet in // Test that we can make a handshake work if the first packet in
// each direction is lost. This gives us predictable loss // each direction is lost. This gives us predictable loss
// rather than having to tune random // rather than having to tune random
TEST_F(SSLStreamAdapterTestDTLS, TestDTLSConnectWithLostFirstPacket) { TEST_F(SSLStreamAdapterTestDTLS,
MAYBE_TestDTLSConnectWithLostFirstPacketNoDelay) {
SetLoseFirstPacket(true); SetLoseFirstPacket(true);
TestHandshake(); TestHandshake();
} }
#ifdef OPENSSL_IS_BORINGSSL
#define MAYBE_TestDTLSConnectWithLostFirstPacketDelay2s \
TestDTLSConnectWithLostFirstPacketDelay2s
#else
#define MAYBE_TestDTLSConnectWithLostFirstPacketDelay2s \
DISABLED_TestDTLSConnectWithLostFirstPacketDelay2s
#endif
// Test a handshake with loss and delay // Test a handshake with loss and delay
TEST_F(SSLStreamAdapterTestDTLS, TestDTLSConnectWithLostFirstPacketDelay2s) { TEST_F(SSLStreamAdapterTestDTLS,
MAYBE_TestDTLSConnectWithLostFirstPacketDelay2s) {
SetLoseFirstPacket(true); SetLoseFirstPacket(true);
SetDelay(2000); SetDelay(2000);
SetHandshakeWait(20000); SetHandshakeWait(20000);