From 90fb11e806d00593452d1e55d7102da0f1678d6a Mon Sep 17 00:00:00 2001 From: Michael Froman Date: Wed, 23 Aug 2023 13:45:46 -0500 Subject: [PATCH] Fix improper buffer size in call to rtc::strcpyn MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit rtc::strcpyn second param should be the size of the destination buffer, not the size of the source string. The result is that the final character (usually a trailing directory path separator) is lost during the copy. This has been masked because FormFileName helpfully adds a trailing path separator if one is missing. BUG=webrtc:15441 Change-Id: I992e69cad86a7e8bc2057ec629063f34c75fe75f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/317502 Commit-Queue: Tomas Gunnarsson Reviewed-by: Tomas Gunnarsson Reviewed-by: Björn Terelius Cr-Commit-Position: refs/heads/main@{#40736} --- modules/audio_processing/logging/apm_data_dumper.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/audio_processing/logging/apm_data_dumper.h b/modules/audio_processing/logging/apm_data_dumper.h index 4ab6baad83..76f8b34c0b 100644 --- a/modules/audio_processing/logging/apm_data_dumper.h +++ b/modules/audio_processing/logging/apm_data_dumper.h @@ -91,7 +91,7 @@ class ApmDataDumper { static void SetOutputDirectory(absl::string_view output_dir) { #if WEBRTC_APM_DEBUG_DUMP == 1 RTC_CHECK_LT(output_dir.size(), kOutputDirMaxLength); - rtc::strcpyn(output_dir_, output_dir.size(), output_dir); + rtc::strcpyn(output_dir_, kOutputDirMaxLength, output_dir); #endif }