diff --git a/webrtc/common_audio/resampler/push_resampler.cc b/webrtc/common_audio/resampler/push_resampler.cc index 127e141a4a..b26774de24 100644 --- a/webrtc/common_audio/resampler/push_resampler.cc +++ b/webrtc/common_audio/resampler/push_resampler.cc @@ -23,9 +23,13 @@ namespace { // due to problems with clang on Windows in debug builds. // For some reason having the DCHECKs inline in the template code // caused the compiler to generate code that threw off the linker. +// TODO(tommi): Re-enable when we've figured out what the problem is. +// http://crbug.com/615050 void CheckValidInitParams(int src_sample_rate_hz, int dst_sample_rate_hz, size_t num_channels) { -#if !defined(WEBRTC_WIN) +// The below checks are temporarily disabled on WEBRTC_WIN due to problems +// with clang debug builds. +#if !defined(WEBRTC_WIN) && defined(__clang__) && !defined(NDEBUG) RTC_DCHECK_GT(src_sample_rate_hz, 0); RTC_DCHECK_GT(dst_sample_rate_hz, 0); RTC_DCHECK_GT(num_channels, 0u); @@ -38,7 +42,11 @@ void CheckExpectedBufferSizes(size_t src_length, size_t num_channels, int src_sample_rate, int dst_sample_rate) { -#if !defined(WEBRTC_WIN) +// The below checks are temporarily disabled on WEBRTC_WIN due to problems +// with clang debug builds. +// TODO(tommi): Re-enable when we've figured out what the problem is. +// http://crbug.com/615050 +#if !defined(WEBRTC_WIN) && defined(__clang__) && !defined(NDEBUG) const size_t src_size_10ms = src_sample_rate * num_channels / 100; const size_t dst_size_10ms = dst_sample_rate * num_channels / 100; RTC_CHECK_EQ(src_length, src_size_10ms); diff --git a/webrtc/common_audio/resampler/push_resampler_unittest.cc b/webrtc/common_audio/resampler/push_resampler_unittest.cc index 8c72a2aecd..53cd495cd0 100644 --- a/webrtc/common_audio/resampler/push_resampler_unittest.cc +++ b/webrtc/common_audio/resampler/push_resampler_unittest.cc @@ -18,7 +18,9 @@ namespace webrtc { // The below tests are temporarily disabled on WEBRTC_WIN due to problems // with clang debug builds. -#if !defined(WEBRTC_WIN) +// TODO(tommi): Re-enable when we've figured out what the problem is. +// http://crbug.com/615050 +#if !defined(WEBRTC_WIN) && defined(__clang__) && !defined(NDEBUG) TEST(PushResamplerTest, VerifiesInputParameters) { PushResampler resampler; EXPECT_EQ(0, resampler.InitializeIfNeeded(16000, 16000, 1)); diff --git a/webrtc/modules/audio_coding/acm2/audio_coding_module_unittest_oldapi.cc b/webrtc/modules/audio_coding/acm2/audio_coding_module_unittest_oldapi.cc index eefe0a5420..55cb5726c1 100644 --- a/webrtc/modules/audio_coding/acm2/audio_coding_module_unittest_oldapi.cc +++ b/webrtc/modules/audio_coding/acm2/audio_coding_module_unittest_oldapi.cc @@ -309,6 +309,11 @@ TEST_F(AudioCodingModuleTestOldApi, VerifyOutputFrame) { EXPECT_EQ(kSampleRateHz, audio_frame.sample_rate_hz_); } +// The below test is temporarily disabled on Windows due to problems +// with clang debug builds. +// TODO(tommi): Re-enable when we've figured out what the problem is. +// http://crbug.com/615050 +#if !defined(WEBRTC_WIN) && defined(__clang__) && !defined(NDEBUG) #if RTC_DCHECK_IS_ON && GTEST_HAS_DEATH_TEST && !defined(WEBRTC_ANDROID) TEST_F(AudioCodingModuleTestOldApi, FailOnZeroDesiredFrequency) { AudioFrame audio_frame; @@ -317,6 +322,7 @@ TEST_F(AudioCodingModuleTestOldApi, FailOnZeroDesiredFrequency) { "dst_sample_rate_hz"); } #endif +#endif // Checks that the transport callback is invoked once for each speech packet. // Also checks that the frame type is kAudioFrameSpeech.