From 90c4b7280cdf5fbd202a213c11d0eed426862557 Mon Sep 17 00:00:00 2001 From: Philipp Hancke Date: Wed, 15 Sep 2021 08:09:33 +0200 Subject: [PATCH] transport-cc: remove unnecessary if block which can no longer happen since the end index and delta sizes are checked in the surrounding condition. Replace with a DCHECK to guard against potential errors. BUG=None Change-Id: I868d54c5923de773f248d10a40dbc6b2c563b0f1 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/231957 Reviewed-by: Johannes Kron Reviewed-by: Danil Chapovalov Commit-Queue: Philipp Hancke Cr-Commit-Position: refs/heads/main@{#35210} --- modules/rtp_rtcp/source/rtcp_packet/transport_feedback.cc | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.cc b/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.cc index 16f88a0783..71d0ab5510 100644 --- a/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.cc +++ b/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.cc @@ -454,11 +454,7 @@ bool TransportFeedback::Parse(const CommonHeader& packet) { // Determine if timestamps, that is, recv_delta are included in the packet. if (end_index >= index + recv_delta_size) { for (size_t delta_size : delta_sizes) { - if (index + delta_size > end_index) { - RTC_LOG(LS_WARNING) << "Buffer overflow while parsing packet."; - Clear(); - return false; - } + RTC_DCHECK_LE(index + delta_size, end_index); switch (delta_size) { case 0: if (include_lost_)