From 90bc1e1badf4465d076062824599857660bea3a3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=85sa=20Persson?= Date: Fri, 31 May 2019 13:29:35 +0200 Subject: [PATCH] Fix comment typo about degradation preference. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Switched comments for MAINTAIN_FRAMERATE and MAINTAIN_RESOLUTION. Bug: none Change-Id: Ibad00978c5096112a119e5e76d40b11752334594 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/139109 Reviewed-by: Stefan Holmer Commit-Queue: Åsa Persson Cr-Commit-Position: refs/heads/master@{#28148} --- api/rtp_parameters.h | 26 ++++++++++++-------------- 1 file changed, 12 insertions(+), 14 deletions(-) diff --git a/api/rtp_parameters.h b/api/rtp_parameters.h index ab7e52f3ff..bc715a0a48 100644 --- a/api/rtp_parameters.h +++ b/api/rtp_parameters.h @@ -80,9 +80,9 @@ enum class DegradationPreference { // Don't take any actions based on over-utilization signals. Not part of the // web API. DISABLED, - // On over-use, request lower frame rate, possibly causing frame drops. - MAINTAIN_FRAMERATE, // On over-use, request lower resolution, possibly causing down-scaling. + MAINTAIN_FRAMERATE, + // On over-use, request lower frame rate, possibly causing frame drops. MAINTAIN_RESOLUTION, // Try to strike a "pleasing" balance between frame rate or resolution. BALANCED, @@ -139,8 +139,7 @@ struct RtpCodecCapability { // TODO(deadbeef): Not implemented. absl::optional max_ptime; - // Preferred packetization time for an RtpReceiver or RtpSender of this - // codec. + // Preferred packetization time for an RtpReceiver or RtpSender of this codec. // TODO(deadbeef): Not implemented. absl::optional ptime; @@ -155,8 +154,8 @@ struct RtpCodecCapability { // Corresponds to "a=fmtp" parameters in SDP. // // Contrary to ORTC, these parameters are named using all lowercase strings. - // This helps make the mapping to SDP simpler, if an application is using - // SDP. Boolean values are represented by the string "1". + // This helps make the mapping to SDP simpler, if an application is using SDP. + // Boolean values are represented by the string "1". std::unordered_map parameters; // Codec-specific parameters that may optionally be signaled to the remote @@ -174,9 +173,9 @@ struct RtpCodecCapability { // TODO(deadbeef): Not implemented. int max_spatial_layer_extensions = 0; - // Whether the implementation can send/receive SVC layers with distinct - // SSRCs. Always false for audio codecs. True for video codecs that support - // scalable video coding with MRST. + // Whether the implementation can send/receive SVC layers with distinct SSRCs. + // Always false for audio codecs. True for video codecs that support scalable + // video coding with MRST. // TODO(deadbeef): Not implemented. bool svc_multi_stream_support = false; @@ -546,8 +545,8 @@ struct RtpCodecParameters { // Corresponds to "a=fmtp" parameters in SDP. // // Contrary to ORTC, these parameters are named using all lowercase strings. - // This helps make the mapping to SDP simpler, if an application is using - // SDP. Boolean values are represented by the string "1". + // This helps make the mapping to SDP simpler, if an application is using SDP. + // Boolean values are represented by the string "1". std::unordered_map parameters; bool operator==(const RtpCodecParameters& o) const { @@ -559,9 +558,8 @@ struct RtpCodecParameters { bool operator!=(const RtpCodecParameters& o) const { return !(*this == o); } }; -// RtpCapabilities is used to represent the static capabilities of an -// endpoint. An application can use these capabilities to construct an -// RtpParameters. +// RtpCapabilities is used to represent the static capabilities of an endpoint. +// An application can use these capabilities to construct an RtpParameters. struct RTC_EXPORT RtpCapabilities { RtpCapabilities(); ~RtpCapabilities();