From 907dcfd0e13b3ea82d8a2b042a1e9a266ef047d0 Mon Sep 17 00:00:00 2001 From: sprang Date: Wed, 5 Aug 2015 01:09:11 -0700 Subject: [PATCH] Increase packet limit in jitter buffer. Especially the VP9 codec currently may overshoot bitrate target at sudden picture changes, resulting in frames over 800 packets. This limit should be reduced again once the codec behaves. BUG=webrtc:4889 Review URL: https://codereview.webrtc.org/1266353003 Cr-Commit-Position: refs/heads/master@{#9675} --- .../video_coding/main/source/jitter_buffer_common.h | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/webrtc/modules/video_coding/main/source/jitter_buffer_common.h b/webrtc/modules/video_coding/main/source/jitter_buffer_common.h index 49a5cb97d2..97af78087a 100644 --- a/webrtc/modules/video_coding/main/source/jitter_buffer_common.h +++ b/webrtc/modules/video_coding/main/source/jitter_buffer_common.h @@ -26,11 +26,13 @@ enum { kPacketsPerFrameMultiplier = 5 }; enum { kFastConvergeThreshold = 5}; enum VCMJitterBufferEnum { - kMaxConsecutiveOldFrames = 60, - kMaxConsecutiveOldPackets = 300, - kMaxPacketsInSession = 800, - kBufferIncStepSizeBytes = 30000, // >20 packets. - kMaxJBFrameSizeBytes = 4000000 // sanity don't go above 4Mbyte. + kMaxConsecutiveOldFrames = 60, + kMaxConsecutiveOldPackets = 300, + // TODO(sprang): Reduce this limit once codecs don't sometimes wildly + // overshoot bitrate target. + kMaxPacketsInSession = 1400, // Allows ~2MB frames. + kBufferIncStepSizeBytes = 30000, // >20 packets. + kMaxJBFrameSizeBytes = 4000000 // sanity don't go above 4Mbyte. }; enum VCMFrameBufferEnum {