From 8f2309478da41cd8b829d022874dfd5ddc58551c Mon Sep 17 00:00:00 2001 From: hbos Date: Tue, 13 Dec 2016 01:45:09 -0800 Subject: [PATCH] New PeerConnectionInterface::GetStats: No bogus default implementation. The Chromium mock implementation implements the new GetStats API, so we can remove this default implementation. BUG=chromium:627816 Review-Url: https://codereview.webrtc.org/2566143002 Cr-Commit-Position: refs/heads/master@{#15563} --- webrtc/api/peerconnectioninterface.h | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/webrtc/api/peerconnectioninterface.h b/webrtc/api/peerconnectioninterface.h index 29badbd8bb..25c1d1bdfb 100644 --- a/webrtc/api/peerconnectioninterface.h +++ b/webrtc/api/peerconnectioninterface.h @@ -474,10 +474,8 @@ class PeerConnectionInterface : public rtc::RefCountInterface { StatsOutputLevel level) = 0; // Gets stats using the new stats collection API, see webrtc/api/stats/. These // will replace old stats collection API when the new API has matured enough. - // TODO(hbos): Default implementation that does nothing only exists as to not - // break third party projects. As soon as they have been updated this should - // be changed to "= 0;". - virtual void GetStats(RTCStatsCollectorCallback* callback) {} + // Master bug: crbug.com/627816 + virtual void GetStats(RTCStatsCollectorCallback* callback) = 0; virtual rtc::scoped_refptr CreateDataChannel( const std::string& label,