admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove field trial WebRTC-Turn-AllowSystemPorts

Browse Source 
There's no trace of it being in use, so let's remove it.

Bug: webrtc:12497
Change-Id: I9e81ef58b459b5a0b9f79b6638231a3a19eb8a0e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/322180
Commit-Queue: Jonas Oreland <jonaso@webrtc.org>
Reviewed-by: Jonas Oreland <jonaso@webrtc.org>
Auto-Submit: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40855}
This commit is contained in:
Harald Alvestrand 2023-10-02 13:39:26 +00:00 committed by WebRTC LUCI CQ
parent bce7ce7ba0
commit 8e007bacda
3 changed files with 0 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
experiments/field_trials.py
View File

@ -757,9 +757,6 @@ POLICY_EXEMPT_FIELD_TRIALS: FrozenSet[FieldTrial] = frozenset([
FieldTrial('WebRTC-TransientSuppressorForcedOff',
'chromium:1186705',
INDEFINITE),
FieldTrial('WebRTC-Turn-AllowSystemPorts',
'webrtc:12497',
date(2024, 4, 1)),
FieldTrial('WebRTC-UseBaseHeavyVP8TL3RateAllocation',
'webrtc:9477',
date(2024, 4, 1)),

5
p2p/base/turn_port.cc
View File

@ -956,11 +956,6 @@ bool TurnPort::AllowedTurnPort(int port,
if (port == 53 || port == 80 || port == 443 || port >= 1024) {
return true;
}
// Allow any port if relevant field trial is set. This allows disabling the
// check.
if (field_trials && field_trials->IsEnabled("WebRTC-Turn-AllowSystemPorts")) {
return true;
}
return false;
}

7
p2p/base/turn_port_unittest.cc
View File

@ -1880,13 +1880,6 @@ TEST_F(TurnPortTest, TestTurnDangerousAlternateServer) {
ASSERT_EQ(0U, turn_port_->Candidates().size());
}
TEST_F(TurnPortTest, TestTurnDangerousServerAllowedWithFieldTrial) {
webrtc::test::ScopedKeyValueConfig override_field_trials(
field_trials_, "WebRTC-Turn-AllowSystemPorts/Enabled/");
CreateTurnPort(kTurnUsername, kTurnPassword, kTurnDangerousProtoAddr);
ASSERT_TRUE(turn_port_);
}
class TurnPortWithMockDnsResolverTest : public TurnPortTest {
public:
TurnPortWithMockDnsResolverTest()