From 8d8bae65e67deed612bc6ec397d6f74481b6a59c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?K=C3=A1ri=20Tristan=20Helgason?= Date: Wed, 8 Apr 2020 20:28:23 +0200 Subject: [PATCH] Migrate to modern selector syntax for ObjcVideoEncoderFactory. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Bug: None Change-Id: I610056b881022bb9408184d1ded4d80eedc410ab Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173200 Commit-Queue: Kári Helgason Reviewed-by: Anders Carlsson Reviewed-by: Kári Helgason Cr-Commit-Position: refs/heads/master@{#31036} --- sdk/objc/native/src/objc_video_encoder_factory.mm | 4 ++-- sdk/objc/unittests/objc_video_encoder_factory_tests.mm | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/sdk/objc/native/src/objc_video_encoder_factory.mm b/sdk/objc/native/src/objc_video_encoder_factory.mm index c2afb2f878..027bfb5189 100644 --- a/sdk/objc/native/src/objc_video_encoder_factory.mm +++ b/sdk/objc/native/src/objc_video_encoder_factory.mm @@ -157,7 +157,7 @@ std::vector ObjCVideoEncoderFactory::GetSupportedFormats() const } std::vector ObjCVideoEncoderFactory::GetImplementations() const { - if ([encoder_factory_ respondsToSelector:SEL("implementations")]) { + if ([encoder_factory_ respondsToSelector:@selector(implementations)]) { std::vector supported_formats; for (RTCVideoCodecInfo *supportedCodec in [encoder_factory_ implementations]) { SdpVideoFormat format = [supportedCodec nativeSdpVideoFormat]; @@ -194,7 +194,7 @@ std::unique_ptr ObjCVideoEncoderFactory::CreateVideoEncoder( std::unique_ptr ObjCVideoEncoderFactory::GetEncoderSelector() const { - if ([encoder_factory_ respondsToSelector:SEL("encoderSelector")]) { + if ([encoder_factory_ respondsToSelector:@selector(encoderSelector)]) { return absl::make_unique([encoder_factory_ encoderSelector]); } return nullptr; diff --git a/sdk/objc/unittests/objc_video_encoder_factory_tests.mm b/sdk/objc/unittests/objc_video_encoder_factory_tests.mm index cd7d739c4e..452c81566c 100644 --- a/sdk/objc/unittests/objc_video_encoder_factory_tests.mm +++ b/sdk/objc/unittests/objc_video_encoder_factory_tests.mm @@ -37,6 +37,7 @@ id CreateEncoderFactoryReturning(int return_code) { id encoderFactoryMock = OCMProtocolMock(@protocol(RTCVideoEncoderFactory)); RTCVideoCodecInfo *supported = [[RTCVideoCodecInfo alloc] initWithName:@"H264" parameters:nil]; OCMStub([encoderFactoryMock supportedCodecs]).andReturn(@[ supported ]); + OCMStub([encoderFactoryMock implementations]).andReturn(@[ supported ]); OCMStub([encoderFactoryMock createEncoder:[OCMArg any]]).andReturn(encoderMock); return encoderFactoryMock; }