admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove unused QpFastFilterLow method

Browse Source 
Bug: None
Change-Id: I63665a3fc9afd57aec8f0f7d2a2a2e631452f6c6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/358080
Auto-Submit: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Åsa Persson <asapersson@webrtc.org>
Commit-Queue: Åsa Persson <asapersson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42704}
This commit is contained in:
Björn Terelius 2024-07-31 09:53:53 +02:00 committed by WebRTC LUCI CQ
parent 3c177dd268
commit 8d7642a9f7
4 changed files with 0 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
modules/video_coding/utility/quality_scaler.cc
View File

@ -260,21 +260,6 @@ void QualityScaler::ReportQp(int qp, int64_t time_sent_us) {
qp_smoother_low_->Add(qp, time_sent_us); qp_smoother_low_->Add(qp, time_sent_us);
} }
bool QualityScaler::QpFastFilterLow() const {
RTC_DCHECK_RUN_ON(&task_checker_);
size_t num_frames = config_.use_all_drop_reasons
? framedrop_percent_all_.Size()
: framedrop_percent_media_opt_.Size();
const size_t kMinNumFrames = 10;
if (num_frames < kMinNumFrames) {
return false; // Wait for more frames before making a decision.
}
absl::optional<int> avg_qp_high = qp_smoother_high_
? qp_smoother_high_->GetAvg()
: average_qp_.GetAverageRoundedDown();
return (avg_qp_high) ? (avg_qp_high.value() <= thresholds_.low) : false;
}
QualityScaler::CheckQpResult QualityScaler::CheckQp() const { QualityScaler::CheckQpResult QualityScaler::CheckQp() const {
RTC_DCHECK_RUN_ON(&task_checker_); RTC_DCHECK_RUN_ON(&task_checker_);
// Should be set through InitEncode -> Should be set by now. // Should be set through InitEncode -> Should be set by now.

1
modules/video_coding/utility/quality_scaler.h
View File

@ -51,7 +51,6 @@ class QualityScaler {
void ReportQp(int qp, int64_t time_sent_us); void ReportQp(int qp, int64_t time_sent_us);
void SetQpThresholds(VideoEncoder::QpThresholds thresholds); void SetQpThresholds(VideoEncoder::QpThresholds thresholds);
bool QpFastFilterLow() const;
// The following members declared protected for testing purposes. // The following members declared protected for testing purposes.
protected: protected:

6
video/adaptation/quality_scaler_resource.cc
View File

@ -61,12 +61,6 @@ void QualityScalerResource::SetQpThresholds(
quality_scaler_->SetQpThresholds(std::move(qp_thresholds)); quality_scaler_->SetQpThresholds(std::move(qp_thresholds));
} }
bool QualityScalerResource::QpFastFilterLow() {
RTC_DCHECK_RUN_ON(encoder_queue());
RTC_DCHECK(is_started());
return quality_scaler_->QpFastFilterLow();
}
void QualityScalerResource::OnEncodeCompleted(const EncodedImage& encoded_image, void QualityScalerResource::OnEncodeCompleted(const EncodedImage& encoded_image,
int64_t time_sent_in_us) { int64_t time_sent_in_us) {
RTC_DCHECK_RUN_ON(encoder_queue()); RTC_DCHECK_RUN_ON(encoder_queue());

1
video/adaptation/quality_scaler_resource.h
View File

@ -42,7 +42,6 @@ class QualityScalerResource : public VideoStreamEncoderResource,
const FieldTrialsView& field_trials); const FieldTrialsView& field_trials);
void StopCheckForOveruse(); void StopCheckForOveruse();
void SetQpThresholds(VideoEncoder::QpThresholds qp_thresholds); void SetQpThresholds(VideoEncoder::QpThresholds qp_thresholds);
bool QpFastFilterLow();
void OnEncodeCompleted(const EncodedImage& encoded_image, void OnEncodeCompleted(const EncodedImage& encoded_image,
int64_t time_sent_in_us); int64_t time_sent_in_us);
void OnFrameDropped(EncodedImageCallback::DropReason reason); void OnFrameDropped(EncodedImageCallback::DropReason reason);