From 8cc126f91bc0dcb3506100d780146850de23b714 Mon Sep 17 00:00:00 2001 From: kjellander Date: Mon, 2 Nov 2015 05:20:41 -0800 Subject: [PATCH] PRESUBMIT: Enable header guard checks for cpplint. This check has always been disabled since the start in https://webrtc-codereview.appspot.com/317011 since it didn't support our style guide back then (wanted our source code to be prefixed with SRC_ in the header guards). I belive this was later fixed in https://chromiumcodereview.appspot.com/15864011. At least it can now be enabled. BUG=5149 NOTRY=True Review URL: https://codereview.webrtc.org/1419203005 Cr-Commit-Position: refs/heads/master@{#10482} --- PRESUBMIT.py | 7 ------- 1 file changed, 7 deletions(-) diff --git a/PRESUBMIT.py b/PRESUBMIT.py index e7ceac94cf..a832761c89 100755 --- a/PRESUBMIT.py +++ b/PRESUBMIT.py @@ -68,13 +68,6 @@ def _CheckApprovedFilesLintClean(input_api, output_api, # pylint: disable=W0212 cpplint._cpplint_state.ResetErrorCounts() - # Justifications for each filter: - # - # - build/header_guard : WebRTC coding style says they should be prefixed - # with WEBRTC_, which is not possible to configure in - # cpplint.py. - cpplint._SetFilters('-build/header_guard') - # Use the strictest verbosity level for cpplint.py (level 1) which is the # default when running cpplint.py from command line. # To make it possible to work with not-yet-converted code, we're only applying