From 8b891cecf793f34c186e35872ba85f19388d201b Mon Sep 17 00:00:00 2001 From: Elad Alon Date: Fri, 15 Sep 2017 14:49:26 +0200 Subject: [PATCH] Remove unused function - RtcEventLog::ParseRtcEventLog() MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The function is not used; removing. BUG=webrtc:8111 NOPRESUBMIT=True Change-Id: Ifd8e4d872e11ffad4bfa178e0ca001470e439043 Reviewed-on: https://webrtc-review.googlesource.com/1234 Commit-Queue: Elad Alon Reviewed-by: Björn Terelius Reviewed-by: Elad Alon Cr-Commit-Position: refs/heads/master@{#19864} --- logging/rtc_event_log/rtc_event_log.cc | 16 ---------------- logging/rtc_event_log/rtc_event_log.h | 10 ---------- 2 files changed, 26 deletions(-) diff --git a/logging/rtc_event_log/rtc_event_log.cc b/logging/rtc_event_log/rtc_event_log.cc index 3ec6c1de49..a6b339093b 100644 --- a/logging/rtc_event_log/rtc_event_log.cc +++ b/logging/rtc_event_log/rtc_event_log.cc @@ -806,22 +806,6 @@ void RtcEventLogImpl::StopLogFile(int64_t stop_time) { RTC_DCHECK(!file_->is_open()); } -bool RtcEventLog::ParseRtcEventLog(const std::string& file_name, - rtclog::EventStream* result) { - char tmp_buffer[1024]; - int bytes_read = 0; - std::unique_ptr dump_file(FileWrapper::Create()); - if (!dump_file->OpenFile(file_name.c_str(), true)) { - return false; - } - ProtoString dump_buffer; - while ((bytes_read = dump_file->Read(tmp_buffer, sizeof(tmp_buffer))) > 0) { - dump_buffer.append(tmp_buffer, bytes_read); - } - dump_file->CloseFile(); - return result->ParseFromString(dump_buffer); -} - #endif // ENABLE_RTC_EVENT_LOG // RtcEventLog member functions. diff --git a/logging/rtc_event_log/rtc_event_log.h b/logging/rtc_event_log/rtc_event_log.h index 757d740625..34b6c7ab13 100644 --- a/logging/rtc_event_log/rtc_event_log.h +++ b/logging/rtc_event_log/rtc_event_log.h @@ -144,16 +144,6 @@ class RtcEventLog { // Logs the result of an unsuccessful probing attempt. virtual void LogProbeResultFailure(int id, ProbeFailureReason failure_reason) = 0; - - // Reads an RtcEventLog file and returns true when reading was successful. - // The result is stored in the given EventStream object. - // The order of the events in the EventStream is implementation defined. - // The current implementation writes a LOG_START event, then the old - // configurations, then the remaining events in timestamp order and finally - // a LOG_END event. However, this might change without further notice. - // TODO(terelius): Change result type to a vector? - static bool ParseRtcEventLog(const std::string& file_name, - rtclog::EventStream* result); }; // No-op implementation is used if flag is not set, or in tests.