From 8b715657fba050d9fd817911f94a8e13b23dfdec Mon Sep 17 00:00:00 2001 From: Per Kjellander Date: Mon, 17 Oct 2022 14:00:53 +0000 Subject: [PATCH] Revert "Enable experiment WebRTC-SendPacketsOnWorkerThread in pc_full_stack_test" This reverts commit 1b3f531da404c200da09f229799e827250347b60. Reason for revert: Simulated network changes has been reverted. In order to see the effect of this experiment, there should not be other larger changes affecting the metrics of a few runs. https://webrtc.googlesource.com/src/+/baf5c9fabd3eba46a2b7747df00b1124a8f5def8 Original change's description: > Enable experiment WebRTC-SendPacketsOnWorkerThread in pc_full_stack_test > > This is a follow up to https://webrtc-review.googlesource.com/c/src/+/278980 to actually enable the experiment in some tests. > > Bug: webrtc:14502 > Change-Id: I166f984bcb94527adc6ebb9169b66abf0f105d76 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/279140 > Reviewed-by: Ilya Nikolaevskiy > Commit-Queue: Per Kjellander > Cr-Commit-Position: refs/heads/main@{#38407} Bug: webrtc:14502 Change-Id: I6e5a607a284186895d1ecd622fdf28f5c1ffd187 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/279600 Bot-Commit: rubber-stamper@appspot.gserviceaccount.com Commit-Queue: Ilya Nikolaevskiy Reviewed-by: Ilya Nikolaevskiy Cr-Commit-Position: refs/heads/main@{#38417} --- video/pc_full_stack_tests.cc | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/video/pc_full_stack_tests.cc b/video/pc_full_stack_tests.cc index d1a1ff6c92..715f3993ba 100644 --- a/video/pc_full_stack_tests.cc +++ b/video/pc_full_stack_tests.cc @@ -97,8 +97,10 @@ std::vector ParameterizedTestParams() { // Use the network thread as worker thread. // Use the worker thread for sending packets. // https://bugs.chromium.org/p/webrtc/issues/detail?id=14502 - {.use_network_thread_as_worker_thread = true, - .field_trials = "WebRTC-SendPacketsOnWorkerThread/Enabled/", + {// TODO(webrtc:14502): Enable field trial soon but let it first run a + // couple of times to get a baseline.. + // .use_network_thread_as_worker_thread = true, + // .field_trials = "WebRTC-SendPacketsOnWorkerThread/Enabled/", .test_case_name_postfix = "_ReducedThreads"}}; }