Mark public ObjC APIs as explicitly visible.

BUG=

Review URL: https://codereview.webrtc.org/1899573002

Cr-Commit-Position: refs/heads/master@{#12431}

webrtc/api/objc/RTCAVFoundationVideoSource.h

@@ -9,6 +9,7 @@
  */
 
 #import "webrtc/api/objc/RTCVideoSource.h"
+#import "webrtc/base/objc/RTCMacros.h"
 
 @class AVCaptureSession;
 @class RTCMediaConstraints;
@@ -23,6 +24,7 @@ NS_ASSUME_NONNULL_BEGIN
  * guarantee its lifetime. Instead, we expose its properties through the ref
  * counted video source interface.
  */
+RTC_EXPORT
 @interface RTCAVFoundationVideoSource : RTCVideoSource
 
 - (instancetype)init NS_UNAVAILABLE;

webrtc/api/objc/RTCAudioTrack.h

@@ -9,9 +9,11 @@
  */
 
 #import "webrtc/api/objc/RTCMediaStreamTrack.h"
+#import "webrtc/base/objc/RTCMacros.h"
 
 NS_ASSUME_NONNULL_BEGIN
 
+RTC_EXPORT
 @interface RTCAudioTrack : RTCMediaStreamTrack
 
 - (instancetype)init NS_UNAVAILABLE;

webrtc/api/objc/RTCConfiguration.h

@@ -10,6 +10,8 @@
 
 #import <Foundation/Foundation.h>
 
+#import "webrtc/base/objc/RTCMacros.h"
+
 @class RTCIceServer;
 
 /**
@@ -50,6 +52,7 @@ typedef NS_ENUM(NSInteger, RTCEncryptionKeyType) {
 
 NS_ASSUME_NONNULL_BEGIN
 
+RTC_EXPORT
 @interface RTCConfiguration : NSObject
 
 /** An array of Ice Servers available to be used by ICE. */

webrtc/api/objc/RTCDataChannel.h

@@ -11,8 +11,11 @@
 #import <AvailabilityMacros.h>
 #import <Foundation/Foundation.h>
 
+#import "webrtc/base/objc/RTCMacros.h"
+
 NS_ASSUME_NONNULL_BEGIN
 
+RTC_EXPORT
 @interface RTCDataBuffer : NSObject
 
 /** NSData representation of the underlying buffer. */
@@ -33,6 +36,7 @@ NS_ASSUME_NONNULL_BEGIN
 
 
 @class RTCDataChannel;
+RTC_EXPORT
 @protocol RTCDataChannelDelegate <NSObject>
 
 /** The data channel state changed. */
@@ -58,7 +62,7 @@ typedef NS_ENUM(NSInteger, RTCDataChannelState) {
   RTCDataChannelStateClosed,
 };
 
-
+RTC_EXPORT
 @interface RTCDataChannel : NSObject
 
 /**

webrtc/api/objc/RTCDataChannelConfiguration.h

@@ -11,8 +11,11 @@
 #import <AvailabilityMacros.h>
 #import <Foundation/Foundation.h>
 
+#import "webrtc/base/objc/RTCMacros.h"
+
 NS_ASSUME_NONNULL_BEGIN
 
+RTC_EXPORT
 @interface RTCDataChannelConfiguration : NSObject
 
 /** Set to YES if ordered delivery is required. */

webrtc/api/objc/RTCEAGLVideoView.h

@@ -12,10 +12,12 @@
 #import <UIKit/UIKit.h>
 
 #import "webrtc/api/objc/RTCVideoRenderer.h"
+#import "webrtc/base/objc/RTCMacros.h"
 
 NS_ASSUME_NONNULL_BEGIN
 
 @class RTCEAGLVideoView;
+RTC_EXPORT
 @protocol RTCEAGLVideoViewDelegate
 
 - (void)videoView:(RTCEAGLVideoView *)videoView didChangeVideoSize:(CGSize)size;
@@ -26,6 +28,7 @@ NS_ASSUME_NONNULL_BEGIN
  * RTCEAGLVideoView is an RTCVideoRenderer which renders video frames in its
  * bounds using OpenGLES 2.0.
  */
+RTC_EXPORT
 @interface RTCEAGLVideoView : UIView <RTCVideoRenderer>
 
 @property(nonatomic, weak) id<RTCEAGLVideoViewDelegate> delegate;

webrtc/api/objc/RTCIceCandidate.h

@@ -10,8 +10,11 @@
 
 #import <Foundation/Foundation.h>
 
+#import "webrtc/base/objc/RTCMacros.h"
+
 NS_ASSUME_NONNULL_BEGIN
 
+RTC_EXPORT
 @interface RTCIceCandidate : NSObject
 
 /**

webrtc/api/objc/RTCIceServer.h

@@ -10,8 +10,11 @@
 
 #import <Foundation/Foundation.h>
 
+#import "webrtc/base/objc/RTCMacros.h"
+
 NS_ASSUME_NONNULL_BEGIN
 
+RTC_EXPORT
 @interface RTCIceServer : NSObject
 
 /** URI(s) for this server represented as NSStrings. */

webrtc/api/objc/RTCMediaConstraints.h

@@ -10,8 +10,11 @@
 
 #import <Foundation/Foundation.h>
 
+#import "webrtc/base/objc/RTCMacros.h"
+
 NS_ASSUME_NONNULL_BEGIN
 
+RTC_EXPORT
 @interface RTCMediaConstraints : NSObject
 
 - (instancetype)init NS_UNAVAILABLE;

webrtc/api/objc/RTCMediaStream.h

@@ -10,12 +10,15 @@
 
 #import <Foundation/Foundation.h>
 
+#import "webrtc/base/objc/RTCMacros.h"
+
 NS_ASSUME_NONNULL_BEGIN
 
 @class RTCAudioTrack;
 @class RTCPeerConnectionFactory;
 @class RTCVideoTrack;
 
+RTC_EXPORT
 @interface RTCMediaStream : NSObject
 
 /** The audio tracks in this stream. */

webrtc/api/objc/RTCMediaStreamTrack.h

@@ -10,6 +10,8 @@
 
 #import <Foundation/Foundation.h>
 
+#import "webrtc/base/objc/RTCMacros.h"
+
 /**
  * Represents the state of the track. This exposes the same states in C++.
  */
@@ -20,6 +22,7 @@ typedef NS_ENUM(NSInteger, RTCMediaStreamTrackState) {
 
 NS_ASSUME_NONNULL_BEGIN
 
+RTC_EXPORT
 @interface RTCMediaStreamTrack : NSObject
 
 /**

webrtc/api/objc/RTCOpenGLVideoRenderer.h

@@ -15,6 +15,8 @@
 #import <AppKit/NSOpenGL.h>
 #endif
 
+#import "webrtc/base/objc/RTCMacros.h"
+
 NS_ASSUME_NONNULL_BEGIN
 
 @class RTCVideoFrame;
@@ -23,6 +25,7 @@ NS_ASSUME_NONNULL_BEGIN
 // the currently bound framebuffer. Supports OpenGL 3.2 and OpenGLES 2.0. OpenGL
 // framebuffer creation and management should be handled elsewhere using the
 // same context used to initialize this class.
+RTC_EXPORT
 @interface RTCOpenGLVideoRenderer : NSObject
 
 // The last successfully drawn frame. Used to avoid drawing frames unnecessarily

webrtc/api/objc/RTCPeerConnection.h

@@ -10,6 +10,8 @@
 
 #import <Foundation/Foundation.h>
 
+#import "webrtc/base/objc/RTCMacros.h"
+
 @class RTCConfiguration;
 @class RTCDataChannel;
 @class RTCDataChannelConfiguration;
@@ -65,6 +67,7 @@ typedef NS_ENUM(NSInteger, RTCStatsOutputLevel) {
 
 @class RTCPeerConnection;
 
+RTC_EXPORT
 @protocol RTCPeerConnectionDelegate <NSObject>
 
 /** Called when the SignalingState changed. */
@@ -100,7 +103,7 @@ typedef NS_ENUM(NSInteger, RTCStatsOutputLevel) {
 
 @end
 
-
+RTC_EXPORT
 @interface RTCPeerConnection : NSObject
 
 /** The object that will be notifed about events such as state changes and

webrtc/api/objc/RTCPeerConnectionFactory.h

@@ -10,6 +10,8 @@
 
 #import <Foundation/Foundation.h>
 
+#import "webrtc/base/objc/RTCMacros.h"
+
 NS_ASSUME_NONNULL_BEGIN
 
 @class RTCAVFoundationVideoSource;
@@ -22,6 +24,7 @@ NS_ASSUME_NONNULL_BEGIN
 @class RTCVideoTrack;
 @protocol RTCPeerConnectionDelegate;
 
+RTC_EXPORT
 @interface RTCPeerConnectionFactory : NSObject
 
 - (instancetype)init NS_DESIGNATED_INITIALIZER;

webrtc/api/objc/RTCRtpEncodingParameters.h

@@ -10,8 +10,11 @@
 
 #import <Foundation/Foundation.h>
 
+#import "webrtc/base/objc/RTCMacros.h"
+
 NS_ASSUME_NONNULL_BEGIN
 
+RTC_EXPORT
 @interface RTCRtpEncodingParameters : NSObject
 
 /** Controls whether the encoding is currently transmitted. */

webrtc/api/objc/RTCRtpParameters.h

@@ -11,9 +11,11 @@
 #import <Foundation/Foundation.h>
 
 #import "webrtc/api/objc/RTCRtpEncodingParameters.h"
+#import "webrtc/base/objc/RTCMacros.h"
 
 NS_ASSUME_NONNULL_BEGIN
 
+RTC_EXPORT
 @interface RTCRtpParameters : NSObject
 
 /** The currently active encodings in the order of preference. */

webrtc/api/objc/RTCRtpSender.h

@@ -12,9 +12,11 @@
 
 #import "webrtc/api/objc/RTCMediaStreamTrack.h"
 #import "webrtc/api/objc/RTCRtpParameters.h"
+#import "webrtc/base/objc/RTCMacros.h"
 
 NS_ASSUME_NONNULL_BEGIN
 
+RTC_EXPORT
 @protocol RTCRtpSender <NSObject>
 
 /** The currently active RTCRtpParameters, as defined in
@@ -36,6 +38,7 @@ NS_ASSUME_NONNULL_BEGIN
 
 @end
 
+RTC_EXPORT
 @interface RTCRtpSender : NSObject <RTCRtpSender>
 
 - (instancetype)init NS_UNAVAILABLE;

webrtc/api/objc/RTCSessionDescription.h

@@ -10,6 +10,8 @@
 
 #import <Foundation/Foundation.h>
 
+#import "webrtc/base/objc/RTCMacros.h"
+
 /**
  * Represents the session description type. This exposes the same types that are
  * in C++, which doesn't include the rollback type that is in the W3C spec.
@@ -22,6 +24,7 @@ typedef NS_ENUM(NSInteger, RTCSdpType) {
 
 NS_ASSUME_NONNULL_BEGIN
 
+RTC_EXPORT
 @interface RTCSessionDescription : NSObject
 
 /** The type of session description. */

webrtc/api/objc/RTCStatsReport.h

@@ -10,9 +10,12 @@
 
 #import <Foundation/Foundation.h>
 
+#import "webrtc/base/objc/RTCMacros.h"
+
 NS_ASSUME_NONNULL_BEGIN
 
 /** This does not currently conform to the spec. */
+RTC_EXPORT
 @interface RTCStatsReport : NSObject
 
 /** Time since 1970-01-01T00:00:00Z in milliseconds. */

webrtc/api/objc/RTCVideoFrame.h

@@ -11,9 +11,12 @@
 #import <AVFoundation/AVFoundation.h>
 #import <Foundation/Foundation.h>
 
+#import "webrtc/base/objc/RTCMacros.h"
+
 NS_ASSUME_NONNULL_BEGIN
 
 // RTCVideoFrame is an ObjectiveC version of cricket::VideoFrame.
+RTC_EXPORT
 @interface RTCVideoFrame : NSObject
 
 /** Width without rotation applied. */

webrtc/api/objc/RTCVideoRenderer.h

@@ -13,10 +13,13 @@
 #import <UIKit/UIKit.h>
 #endif
 
+#import "webrtc/base/objc/RTCMacros.h"
+
 NS_ASSUME_NONNULL_BEGIN
 
 @class RTCVideoFrame;
 
+RTC_EXPORT
 @protocol RTCVideoRenderer <NSObject>
 
 /** The size of the frame. */

webrtc/api/objc/RTCVideoSource.h

@@ -10,6 +10,8 @@
 
 #import <Foundation/Foundation.h>
 
+#import "webrtc/base/objc/RTCMacros.h"
+
 typedef NS_ENUM(NSInteger, RTCSourceState) {
   RTCSourceStateInitializing,
   RTCSourceStateLive,
@@ -19,6 +21,7 @@ typedef NS_ENUM(NSInteger, RTCSourceState) {
 
 NS_ASSUME_NONNULL_BEGIN
 
+RTC_EXPORT
 @interface RTCVideoSource : NSObject
 
 /** The current state of the RTCVideoSource. */

webrtc/api/objc/RTCVideoTrack.h

@@ -10,12 +10,15 @@
 
 #import "webrtc/api/objc/RTCMediaStreamTrack.h"
 
+#import "webrtc/base/objc/RTCMacros.h"
+
 NS_ASSUME_NONNULL_BEGIN
 
 @protocol RTCVideoRenderer;
 @class RTCPeerConnectionFactory;
 @class RTCVideoSource;
 
+RTC_EXPORT
 @interface RTCVideoTrack : RTCMediaStreamTrack
 
 /** The video source for this video track. */

webrtc/base/objc/RTCCameraPreviewView.h

@@ -11,12 +11,15 @@
 #import <Foundation/Foundation.h>
 #import <UIKit/UIKit.h>
 
+#import "webrtc/base/objc/RTCMacros.h"
+
 @class AVCaptureSession;
 @class RTCAVFoundationVideoSource;
 
 /** RTCCameraPreviewView is a view that renders local video from an
  *  AVCaptureSession.
  */
+RTC_EXPORT
 @interface RTCCameraPreviewView : UIView
 
 /** The capture session being rendered in the view. Capture session

webrtc/base/objc/RTCDispatcher.h

@@ -10,6 +10,8 @@
 
 #import <Foundation/Foundation.h>
 
+#import "webrtc/base/objc/RTCMacros.h"
+
 typedef NS_ENUM(NSInteger, RTCDispatcherQueueType) {
   // Main dispatcher queue.
   RTCDispatcherTypeMain,
@@ -23,6 +25,7 @@ typedef NS_ENUM(NSInteger, RTCDispatcherQueueType) {
 /** Dispatcher that asynchronously dispatches blocks to a specific
  *  shared dispatch queue.
  */
+RTC_EXPORT
 @interface RTCDispatcher : NSObject
 
 - (instancetype)init NS_UNAVAILABLE;

webrtc/base/objc/RTCFieldTrials.h

@@ -8,10 +8,10 @@
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
-#include "webrtc/base/objc/RTCMacros.h"
-
 #import <Foundation/Foundation.h>
 
+#import "webrtc/base/objc/RTCMacros.h"
+
 typedef NS_OPTIONS(NSUInteger, RTCFieldTrialOptions) {
   RTCFieldTrialOptionsNone = 0,
   RTCFieldTrialOptionsSendSideBwe = 1 << 0,
@@ -20,4 +20,4 @@ typedef NS_OPTIONS(NSUInteger, RTCFieldTrialOptions) {
 /** Must be called before any other call into WebRTC. See:
  *  webrtc/system_wrappers/include/field_trial_default.h
  */
-RTC_EXPORT void RTCInitFieldTrials(RTCFieldTrialOptions options);
+RTC_EXTERN void RTCInitFieldTrials(RTCFieldTrialOptions options);

webrtc/base/objc/RTCFileLogger.h

@@ -10,6 +10,8 @@
 
 #import <Foundation/Foundation.h>
 
+#import "webrtc/base/objc/RTCMacros.h"
+
 typedef NS_ENUM(NSUInteger, RTCFileLoggerSeverity) {
   RTCFileLoggerSeverityVerbose,
   RTCFileLoggerSeverityInfo,
@@ -31,6 +33,7 @@ NS_ASSUME_NONNULL_BEGIN
 // are preserved while the middle section is overwritten instead.
 // For kRTCFileLoggerTypeApp, the oldest log is overwritten.
 // This class is not threadsafe.
+RTC_EXPORT
 @interface RTCFileLogger : NSObject
 
 // The severity level to capture. The default is kRTCFileLoggerSeverityInfo.

webrtc/base/objc/RTCLogging.h

@@ -10,6 +10,8 @@
 
 #import <Foundation/Foundation.h>
 
+#import "webrtc/base/objc/RTCMacros.h"
+
 // Subset of rtc::LoggingSeverity.
 typedef NS_ENUM(NSInteger, RTCLoggingSeverity) {
   RTCLoggingSeverityVerbose,
@@ -18,24 +20,16 @@ typedef NS_ENUM(NSInteger, RTCLoggingSeverity) {
   RTCLoggingSeverityError,
 };
 
-#if defined(__cplusplus)
-extern "C" void RTCLogEx(RTCLoggingSeverity severity, NSString* log_string);
-extern "C" void RTCSetMinDebugLogLevel(RTCLoggingSeverity severity);
-extern "C" NSString* RTCFileName(const char* filePath);
-#else
-
 // Wrapper for C++ LOG(sev) macros.
 // Logs the log string to the webrtc logstream for the given severity.
-extern void RTCLogEx(RTCLoggingSeverity severity, NSString* log_string);
+RTC_EXTERN void RTCLogEx(RTCLoggingSeverity severity, NSString* log_string);
 
 // Wrapper for rtc::LogMessage::LogToDebug.
 // Sets the minimum severity to be logged to console.
-extern void RTCSetMinDebugLogLevel(RTCLoggingSeverity severity);
+RTC_EXTERN void RTCSetMinDebugLogLevel(RTCLoggingSeverity severity);
 
 // Returns the filename with the path prefix removed.
-extern NSString* RTCFileName(const char* filePath);
-
-#endif
+RTC_EXTERN NSString* RTCFileName(const char* filePath);
 
 // Some convenience macros.
 

webrtc/base/objc/RTCMacros.h

@@ -11,10 +11,12 @@
 #ifndef WEBRTC_BASE_OBJC_RTC_MACROS_H_
 #define WEBRTC_BASE_OBJC_RTC_MACROS_H_
 
+#define RTC_EXPORT __attribute__((visibility("default")))
+
 #if defined(__cplusplus)
-#define RTC_EXPORT extern "C"
+#define RTC_EXTERN extern "C" RTC_EXPORT
 #else
-#define RTC_EXPORT extern
+#define RTC_EXTERN extern RTC_EXPORT
 #endif
 
 #ifdef __OBJC__

webrtc/base/objc/RTCSSLAdapter.h

@@ -16,5 +16,5 @@
  * Initialize and clean up the SSL library. Failure is fatal. These call the
  * corresponding functions in webrtc/base/ssladapter.h.
  */
-RTC_EXPORT BOOL RTCInitializeSSL();
-RTC_EXPORT BOOL RTCCleanupSSL();
+RTC_EXTERN BOOL RTCInitializeSSL();
+RTC_EXTERN BOOL RTCCleanupSSL();

webrtc/base/objc/RTCTracing.h

@@ -12,10 +12,10 @@
 
 #import "webrtc/base/objc/RTCMacros.h"
 
-RTC_EXPORT void RTCSetupInternalTracer();
+RTC_EXTERN void RTCSetupInternalTracer();
 /** Starts capture to specified file. Must be a valid writable path.
  *  Returns YES if capture starts.
  */
-RTC_EXPORT BOOL RTCStartInternalCapture(NSString *filePath);
-RTC_EXPORT void RTCStopInternalCapture();
-RTC_EXPORT void RTCShutdownInternalTracer();
+RTC_EXTERN BOOL RTCStartInternalCapture(NSString *filePath);
+RTC_EXTERN void RTCStopInternalCapture();
+RTC_EXTERN void RTCShutdownInternalTracer();

webrtc/base/objc/RTCUIApplication.h

@@ -15,7 +15,7 @@
 
 #if defined(WEBRTC_IOS)
 /** Convenience function to get UIApplicationState from C++. */
-RTC_EXPORT bool RTCIsUIApplicationActive();
+RTC_EXTERN bool RTCIsUIApplicationActive();
 #endif  // WEBRTC_IOS
 
 #endif  // WEBRTC_BASE_OBJC_RTC_UI_APPLICATION_H_