From 8a9b0f8e02c7539cf21c3de174dad0f8e2becc06 Mon Sep 17 00:00:00 2001 From: peah Date: Tue, 4 Oct 2016 00:06:04 -0700 Subject: [PATCH] The current format of the log output of the level controller differs from the rest of the log. Furthermore, it is hard to automatically parse. This CL changes the format to be a JSON-type format which does not have those issues. BUG=webrtc:6408 Review-Url: https://codereview.webrtc.org/2364553003 Cr-Commit-Position: refs/heads/master@{#14489} --- .../level_controller/level_controller.cc | 30 +++++++++---------- 1 file changed, 14 insertions(+), 16 deletions(-) diff --git a/webrtc/modules/audio_processing/level_controller/level_controller.cc b/webrtc/modules/audio_processing/level_controller/level_controller.cc index c0edeb91c5..247b7d0c61 100644 --- a/webrtc/modules/audio_processing/level_controller/level_controller.cc +++ b/webrtc/modules/audio_processing/level_controller/level_controller.cc @@ -156,23 +156,21 @@ void LevelController::Metrics::Update(float long_term_peak_level, const int frame_peak_level_dbfs = static_cast( 10 * log10(frame_peak_level * frame_peak_level + 1e-10f) - kdBFSOffset); - LOG(LS_INFO) << "Level Controller metrics: " << std::endl - << "Max noise power: " << max_noise_power_dbfs - << " dBFS" << std::endl - << "Average noise power: " << average_noise_power_dbfs - << " dBFS" << std::endl - << "Max long term peak level: " << max_peak_level_dbfs - << " dBFS" << std::endl + LOG(LS_INFO) << "Level Controller metrics: {" + << "Max noise power: " << max_noise_power_dbfs << " dBFS, " + << "Average noise power: " << average_noise_power_dbfs + << " dBFS, " + << "Max long term peak level: " << max_peak_level_dbfs + << " dBFS, " << "Average long term peak level: " << average_peak_level_dbfs - << " dBFS" << std::endl - << "Max gain: " << max_gain_db << " dB" - << std::endl - << "Average gain: " << average_gain_db << " dB" - << std::endl - << "Long term peak level: " - << long_term_peak_level_dbfs << " dBFS" << std::endl - << "Last frame peak level: " << frame_peak_level_dbfs - << " dBFS"; + << " dBFS, " + << "Max gain: " << max_gain_db << " dB, " + << "Average gain: " << average_gain_db << " dB, " + << "Long term peak level: " << long_term_peak_level_dbfs + << " dBFS, " + << "Last frame peak level: " << frame_peak_level_dbfs + << " dBFS" + << "}"; Reset(); }