From 8a0c1f58cc09822bd5ed19d72551c70c40ea1cca Mon Sep 17 00:00:00 2001 From: Sebastian Jansson Date: Mon, 11 Mar 2019 10:24:51 +0100 Subject: [PATCH] Don't reset bitrate when allocatable minimum changes. This fixes an issue where the time between freezes dropped in perf tests. This was triggered by resetting and updating the bitrates immediately if the min allocatable bitrate changed, causing a drop in target bitrate. With this CL, the change in min bitrate will not take effect until we get more data. Bug: chromium:940349 Change-Id: Ia680a5f1cfe71847ef90669987e7b89b240b9524 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126625 Reviewed-by: Christoffer Rodbro Commit-Queue: Sebastian Jansson Cr-Commit-Position: refs/heads/master@{#27054} --- .../congestion_controller/goog_cc/goog_cc_network_control.cc | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/modules/congestion_controller/goog_cc/goog_cc_network_control.cc b/modules/congestion_controller/goog_cc/goog_cc_network_control.cc index 807e1d89f2..283ca983e9 100644 --- a/modules/congestion_controller/goog_cc/goog_cc_network_control.cc +++ b/modules/congestion_controller/goog_cc/goog_cc_network_control.cc @@ -287,10 +287,8 @@ NetworkControlUpdate GoogCcNetworkController::OnStreamsConfig( if (use_min_allocatable_as_lower_bound_) { ClampConstraints(); - bandwidth_estimation_->SetBitrates(starting_rate_, min_data_rate_, - max_data_rate_, msg.at_time); delay_based_bwe_->SetMinBitrate(min_data_rate_); - MaybeTriggerOnNetworkChanged(&update, msg.at_time); + bandwidth_estimation_->SetMinMaxBitrate(min_data_rate_, max_data_rate_); } } if (msg.max_padding_rate && *msg.max_padding_rate != max_padding_rate_) {