From 893c07f2093966ca00d7d52c1a90ca8fc3e39a0d Mon Sep 17 00:00:00 2001 From: "kjellander@webrtc.org" Date: Fri, 18 Oct 2013 14:42:27 +0000 Subject: [PATCH] Disable the -Wno-unused-const-variable Clang warning on Mac In r4966 this was disabled on Linux for WebRTC code in order to detect any new unused const variables. This CL does the same for Mac. BUG=none TEST=added an unused const and verified compilation fails when this patch is applied. Mac trybots passing as well. R=andrew@webrtc.org Review URL: https://webrtc-codereview.appspot.com/2459004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@4997 4adac7df-926f-26a2-2b94-8c16560cd09d --- webrtc/build/common.gypi | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/webrtc/build/common.gypi b/webrtc/build/common.gypi index 73dda8dcdf..f313402ed6 100644 --- a/webrtc/build/common.gypi +++ b/webrtc/build/common.gypi @@ -312,10 +312,12 @@ ], }], ['clang==1', { - 'cflags!': [ - # TODO(kjellander): Remove when Chromium's common.gypi enables it. - '-Wno-unused-const-variable', - ], + # TODO(kjellander): Remove when Chromium's common.gypi enables this + # warning by default (http://crbug.com/307668). + 'cflags!': ['-Wno-unused-const-variable',], + 'xcode_settings': { + 'WARNING_CFLAGS!': ['-Wno-unused-const-variable',], + }, }], ], # conditions 'direct_dependent_settings': {