admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Guard against uninitialized packetization modes.

Browse Source 
This change inserts a RTC_CHECK for illegal packetization modes
when RTP packetizers are constructed.

This should help find places where this field is not initialized.

BUG=webrtc:6858

Review-Url: https://codereview.webrtc.org/2575073002
Cr-Commit-Position: refs/heads/master@{#15614}
This commit is contained in:
hta 2016-12-14 12:48:28 -08:00 committed by Commit bot
parent d30bd18048
commit 88cf05cf73
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
webrtc/modules/rtp_rtcp/source/rtp_format_h264.cc
View File

@ -81,7 +81,11 @@ bool ParseStapAStartOffsets(const uint8_t* nalu_ptr,
RtpPacketizerH264::RtpPacketizerH264(size_t max_payload_len,
H264PacketizationMode packetization_mode)
: max_payload_len_(max_payload_len),
packetization_mode_(packetization_mode) {}
packetization_mode_(packetization_mode) {
// Guard against uninitialized memory in packetization_mode.
RTC_CHECK(packetization_mode == H264PacketizationMode::NonInterleaved ||
packetization_mode == H264PacketizationMode::SingleNalUnit);
}
RtpPacketizerH264::~RtpPacketizerH264() {
}