From 88c1d2bc0f8468f04cb05a536c5194f9bb9d0e50 Mon Sep 17 00:00:00 2001 From: terelius Date: Mon, 1 Aug 2016 05:20:33 -0700 Subject: [PATCH] Don't use LOG_END timestamp to compute RtcEventLog duration. The LOG_END time is incorrect if the event log is stopped by the file size limit instead of a duration limit or a manual stop. This makes the call appear to be very long (10^13 seconds) in the analysis tool. This CL is a workaround for that problem. BUG=webrtc:6138 Review-Url: https://codereview.webrtc.org/2176663002 Cr-Commit-Position: refs/heads/master@{#13585} --- webrtc/tools/event_log_visualizer/analyzer.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/webrtc/tools/event_log_visualizer/analyzer.cc b/webrtc/tools/event_log_visualizer/analyzer.cc index 26be553f9a..ba92da7ad6 100644 --- a/webrtc/tools/event_log_visualizer/analyzer.cc +++ b/webrtc/tools/event_log_visualizer/analyzer.cc @@ -137,7 +137,9 @@ EventLogAnalyzer::EventLogAnalyzer(const ParsedRtcEventLog& log) if (event_type != ParsedRtcEventLog::VIDEO_RECEIVER_CONFIG_EVENT && event_type != ParsedRtcEventLog::VIDEO_SENDER_CONFIG_EVENT && event_type != ParsedRtcEventLog::AUDIO_RECEIVER_CONFIG_EVENT && - event_type != ParsedRtcEventLog::AUDIO_SENDER_CONFIG_EVENT) { + event_type != ParsedRtcEventLog::AUDIO_SENDER_CONFIG_EVENT && + event_type != ParsedRtcEventLog::LOG_START && + event_type != ParsedRtcEventLog::LOG_END) { uint64_t timestamp = parsed_log_.GetTimestamp(i); first_timestamp = std::min(first_timestamp, timestamp); last_timestamp = std::max(last_timestamp, timestamp);