From 88329b9266a34bfb78a619d7cbf678da5e293f98 Mon Sep 17 00:00:00 2001 From: Harald Alvestrand Date: Fri, 16 Oct 2020 15:01:05 +0000 Subject: [PATCH] Deprecate GetRemoteAudioSSLCertificate This CL adds the RTC_DEPRECATED markers. Bug: webrtc:12054 Change-Id: Id7d0b49caa39d64f3e768922293230e50a2a8f08 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/188821 Commit-Queue: Harald Alvestrand Reviewed-by: Mirko Bonadei Cr-Commit-Position: refs/heads/master@{#32424} --- pc/peer_connection.h | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/pc/peer_connection.h b/pc/peer_connection.h index 8a2be2822f..9949fcb8f0 100644 --- a/pc/peer_connection.h +++ b/pc/peer_connection.h @@ -107,13 +107,15 @@ class PeerConnection : public PeerConnectionInternal, // remote side. This will become populated once the DTLS connection with the // peer has been completed, as indicated by the ICE connection state // transitioning to kIceConnectionCompleted. - // Note that this will be removed once we implement RTCDtlsTransport which - // has standardized method for getting this information. + // Deprecated - users should insted query the DTLS transpport for this info. // See https://www.w3.org/TR/webrtc/#rtcdtlstransport-interface - std::unique_ptr GetRemoteAudioSSLCertificate(); + + RTC_DEPRECATED std::unique_ptr + GetRemoteAudioSSLCertificate(); // Version of the above method that returns the full certificate chain. - std::unique_ptr GetRemoteAudioSSLCertChain(); + RTC_DEPRECATED std::unique_ptr + GetRemoteAudioSSLCertChain(); rtc::scoped_refptr CreateSender( const std::string& kind,