From 87c5463dfd646f89530c21ed070936b90fe046ff Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?K=C3=A1ri=20Tristan=20Helgason?= Date: Thu, 5 Apr 2018 09:56:14 +0200 Subject: [PATCH] Correctly set iOS VideoToolbox encoder start bitrate. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The settings struct specifies bitrate in kbps, but we are treating it as bps. Bug: webrtc:9113 Change-Id: I27745da93aaec68041ea4283b45eccb35d820793 Reviewed-on: https://webrtc-review.googlesource.com/66960 Reviewed-by: Anders Carlsson Commit-Queue: Kári Helgason Cr-Commit-Position: refs/heads/master@{#22743} --- sdk/objc/Framework/Classes/VideoToolbox/RTCVideoEncoderH264.mm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk/objc/Framework/Classes/VideoToolbox/RTCVideoEncoderH264.mm b/sdk/objc/Framework/Classes/VideoToolbox/RTCVideoEncoderH264.mm index a818c27d1e..792dad5ef2 100644 --- a/sdk/objc/Framework/Classes/VideoToolbox/RTCVideoEncoderH264.mm +++ b/sdk/objc/Framework/Classes/VideoToolbox/RTCVideoEncoderH264.mm @@ -330,7 +330,7 @@ CFStringRef ExtractProfile(webrtc::SdpVideoFormat videoFormat) { _mode = settings.mode; // We can only set average bitrate on the HW encoder. - _targetBitrateBps = settings.startBitrate; + _targetBitrateBps = settings.startBitrate * 1000; // startBitrate is in kbps. _bitrateAdjuster->SetTargetBitrateBps(_targetBitrateBps); // TODO(tkchin): Try setting payload size via