From 875df7e14027098907f2819841ce3d4c6d21471a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jes=C3=BAs=20de=20Vicente=20Pe=C3=B1a?= Date: Mon, 20 Dec 2021 14:06:45 +0100 Subject: [PATCH] AEC3: Changing the default for the use_conservative_tail_frequency_response flag. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Bug: webrtc:13173 Change-Id: If53ca45b28690d7d2ed744508b5a2ef7c8448172 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/241783 Reviewed-by: Per Åhgren Commit-Queue: Jesus de Vicente Pena Cr-Commit-Position: refs/heads/main@{#35561} --- api/audio/echo_canceller3_config.h | 2 +- modules/audio_processing/aec3/echo_canceller3.cc | 5 +++++ resources/audio_processing/output_data_float.pb.sha1 | 2 +- resources/audio_processing/output_data_float_avx2.pb.sha1 | 2 +- 4 files changed, 8 insertions(+), 3 deletions(-) diff --git a/api/audio/echo_canceller3_config.h b/api/audio/echo_canceller3_config.h index c2ee797727..1fd403652a 100644 --- a/api/audio/echo_canceller3_config.h +++ b/api/audio/echo_canceller3_config.h @@ -112,7 +112,7 @@ struct RTC_EXPORT EchoCanceller3Config { bool echo_can_saturate = true; bool bounded_erl = false; bool erle_onset_compensation_in_dominant_nearend = false; - bool use_conservative_tail_frequency_response = false; + bool use_conservative_tail_frequency_response = true; } ep_strength; struct EchoAudibility { diff --git a/modules/audio_processing/aec3/echo_canceller3.cc b/modules/audio_processing/aec3/echo_canceller3.cc index 58fb6a49a3..419a056d20 100644 --- a/modules/audio_processing/aec3/echo_canceller3.cc +++ b/modules/audio_processing/aec3/echo_canceller3.cc @@ -290,6 +290,11 @@ EchoCanceller3Config AdjustConfig(const EchoCanceller3Config& config) { adjusted_cfg.ep_strength.use_conservative_tail_frequency_response = true; } + if (field_trial::IsDisabled("WebRTC-Aec3ConservativeTailFreqResponse")) { + adjusted_cfg.ep_strength.use_conservative_tail_frequency_response = false; + } + + if (field_trial::IsEnabled("WebRTC-Aec3ShortHeadroomKillSwitch")) { // Two blocks headroom. adjusted_cfg.delay.delay_headroom_samples = kBlockSize * 2; diff --git a/resources/audio_processing/output_data_float.pb.sha1 b/resources/audio_processing/output_data_float.pb.sha1 index d3375949ac..85e628cb76 100644 --- a/resources/audio_processing/output_data_float.pb.sha1 +++ b/resources/audio_processing/output_data_float.pb.sha1 @@ -1 +1 @@ -749efdfd1e3c3ace434b3673dac9ce4938534449 \ No newline at end of file +d7dadc14736be65465a79054ce29413cd4cc1ccd \ No newline at end of file diff --git a/resources/audio_processing/output_data_float_avx2.pb.sha1 b/resources/audio_processing/output_data_float_avx2.pb.sha1 index 79a95efc0e..63f9887265 100644 --- a/resources/audio_processing/output_data_float_avx2.pb.sha1 +++ b/resources/audio_processing/output_data_float_avx2.pb.sha1 @@ -1 +1 @@ -78c1a84de332173863c997538aa19b8cdcba5020 \ No newline at end of file +40df0b4e636bb59fe258b93f8aab7fd2d3f6440d \ No newline at end of file