From 86fbea10a56353e23b101cb854cae0c97313ab12 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Beno=C3=AEt=20Liz=C3=A9?= Date: Wed, 20 Jun 2018 14:00:34 +0200 Subject: [PATCH] Fix VideoSendStreamImpl::OnPacketFeedbackError: operator precedence. in: if (auto it = some_set.find(some_value) != some_set.end()) {} "it" is bool, not an iterator. Bug: webrtc:9652 Change-Id: Icfaab685f4e2f4456e24d5a14b11309dddfdc0fe Reviewed-on: https://webrtc-review.googlesource.com/84420 Commit-Queue: Benoit Lize Reviewed-by: Stefan Holmer Cr-Commit-Position: refs/heads/master@{#24389} --- video/video_send_stream_impl.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/video/video_send_stream_impl.cc b/video/video_send_stream_impl.cc index 0c158567bb..cf4bf870ac 100644 --- a/video/video_send_stream_impl.cc +++ b/video/video_send_stream_impl.cc @@ -709,8 +709,8 @@ void VideoSendStreamImpl::OnPacketFeedbackVector( } // Lost feedbacks are not considered to be lost packets. for (const PacketFeedback& packet : packet_feedback_vector) { - if (auto it = feedback_packet_seq_num_set_.find(packet.sequence_number) != - feedback_packet_seq_num_set_.end()) { + auto it = feedback_packet_seq_num_set_.find(packet.sequence_number); + if (it != feedback_packet_seq_num_set_.end()) { const bool lost = packet.arrival_time_ms == PacketFeedback::kNotReceived; loss_mask_vector_.push_back(lost); feedback_packet_seq_num_set_.erase(it);