From 86e0ea5711cfef95960ffcc8b6d918c67576e5c9 Mon Sep 17 00:00:00 2001 From: Anders Carlsson Date: Mon, 6 May 2019 15:04:59 +0200 Subject: [PATCH] Remove bitratePriority from the Obj-C RTCRtpEncodingParameters wrapper. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This was added in CL 135122, but the bitratePriority parameter is not standard and not implemented in a way users would expect. So it should actually not be exposed in the Obj-C SDK. Bug: webrtc:10438 Change-Id: I801ce940a32701d2703e951ef2b601c606aa2111 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/135287 Reviewed-by: Kári Helgason Commit-Queue: Anders Carlsson Cr-Commit-Position: refs/heads/master@{#27861} --- sdk/objc/api/peerconnection/RTCRtpEncodingParameters.h | 3 --- sdk/objc/api/peerconnection/RTCRtpEncodingParameters.mm | 3 --- 2 files changed, 6 deletions(-) diff --git a/sdk/objc/api/peerconnection/RTCRtpEncodingParameters.h b/sdk/objc/api/peerconnection/RTCRtpEncodingParameters.h index c3e38893a8..16eabf9b2f 100644 --- a/sdk/objc/api/peerconnection/RTCRtpEncodingParameters.h +++ b/sdk/objc/api/peerconnection/RTCRtpEncodingParameters.h @@ -51,9 +51,6 @@ RTC_OBJC_EXPORT /** The SSRC being used by this encoding. */ @property(nonatomic, readonly, nullable) NSNumber *ssrc; -/** The relative bitrate priority. */ -@property(nonatomic, assign) double bitratePriority; - /** The relative DiffServ Code Point priority. */ @property(nonatomic, assign) double networkPriority; diff --git a/sdk/objc/api/peerconnection/RTCRtpEncodingParameters.mm b/sdk/objc/api/peerconnection/RTCRtpEncodingParameters.mm index 5b8c27469d..7378473f50 100644 --- a/sdk/objc/api/peerconnection/RTCRtpEncodingParameters.mm +++ b/sdk/objc/api/peerconnection/RTCRtpEncodingParameters.mm @@ -22,7 +22,6 @@ @synthesize numTemporalLayers = _numTemporalLayers; @synthesize scaleResolutionDownBy = _scaleResolutionDownBy; @synthesize ssrc = _ssrc; -@synthesize bitratePriority = _bitratePriority; @synthesize networkPriority = _networkPriority; - (instancetype)init { @@ -57,7 +56,6 @@ if (nativeParameters.ssrc) { _ssrc = [NSNumber numberWithUnsignedLong:*nativeParameters.ssrc]; } - _bitratePriority = nativeParameters.bitrate_priority; _networkPriority = nativeParameters.network_priority; } return self; @@ -88,7 +86,6 @@ if (_ssrc != nil) { parameters.ssrc = absl::optional(_ssrc.unsignedLongValue); } - parameters.bitrate_priority = _bitratePriority; parameters.network_priority = _networkPriority; return parameters; }