From 86ccd7bfbafc4fd2d86ff05563d52d0aec168d0a Mon Sep 17 00:00:00 2001 From: sakal Date: Mon, 22 Aug 2016 00:26:01 -0700 Subject: [PATCH] Revert of Add field_trial_default dependency to libjingle_peerconnection (patchset #3 id:40001 of https://codereview.webrtc.org/2120673004/ ) Reason for revert: Breaks chromium. Original issue's description: > Add field_trial_default dependency to libjingle_peerconnection > > This is needed for webrtc::field_trial::FindFullName in peerconnection.cc > > NOTRY=True > > Committed: https://crrev.com/a7a01df2aebe7108afad208ccd0341c2f0bc7b3b > Cr-Commit-Position: refs/heads/master@{#13836} TBR=pthatcher@webrtc.org,pthatcher@chromium.org,kjellander@webrtc.org,arlolra@gmail.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.webrtc.org/2263063002 Cr-Commit-Position: refs/heads/master@{#13837} --- AUTHORS | 1 - webrtc/api/BUILD.gn | 2 +- webrtc/api/api.gyp | 2 +- 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/AUTHORS b/AUTHORS index c569ade108..6d1ee96145 100644 --- a/AUTHORS +++ b/AUTHORS @@ -4,7 +4,6 @@ Alexander Brauckmann Andrew MacDonald Anil Kumar -Arlo Breault Ben Strong Bob Withers Bridger Maxwell diff --git a/webrtc/api/BUILD.gn b/webrtc/api/BUILD.gn index 6b7c5f98c5..a8e27d6aa6 100644 --- a/webrtc/api/BUILD.gn +++ b/webrtc/api/BUILD.gn @@ -113,7 +113,6 @@ source_set("libjingle_peerconnection") { "../call", "../media", "../pc", - "../system_wrappers:field_trial_default", ] if (rtc_use_quic) { @@ -199,6 +198,7 @@ if (is_android && !build_with_chromium) { deps = [ ":libjingle_peerconnection", + "../system_wrappers:field_trial_default", "../system_wrappers:metrics_default", ] diff --git a/webrtc/api/api.gyp b/webrtc/api/api.gyp index e6fa0c4e39..86a55fd9d2 100644 --- a/webrtc/api/api.gyp +++ b/webrtc/api/api.gyp @@ -30,6 +30,7 @@ 'target_name': 'libjingle_peerconnection_jni', 'type': 'static_library', 'dependencies': [ + '<(webrtc_root)/system_wrappers/system_wrappers.gyp:field_trial_default', '<(webrtc_root)/system_wrappers/system_wrappers.gyp:metrics_default', 'libjingle_peerconnection', ], @@ -103,7 +104,6 @@ 'dependencies': [ '<(webrtc_root)/media/media.gyp:rtc_media', '<(webrtc_root)/pc/pc.gyp:rtc_pc', - '<(webrtc_root)/system_wrappers/system_wrappers.gyp:field_trial_default', ], 'sources': [ 'audiotrack.cc',