admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "Disable some PortAllocatorTest on tsan due to flakiness"

Browse Source 
This reverts commit 491bd534ef726456883ec372562d1c8fef82e7ca.

TBR=kjellander@webrtc.org
BUG=4743

Review URL: https://codereview.webrtc.org/1157743008

Cr-Commit-Position: refs/heads/master@{#9375}
This commit is contained in:
Erik Språng 2015-06-05 09:31:05 +02:00
parent f019efa36a
commit 85cf3c0794
1 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
webrtc/p2p/client/portallocator_unittest.cc
View File

@ -472,10 +472,6 @@ TEST_F(PortAllocatorTest, TestDisableAdapterEnumerationMultipleInterfaces) {
CheckDisableAdapterEnumeration();
}
// Disable for TSan v2, see
// https://code.google.com/p/webrtc/issues/detail?id=4743 for details.
#if !defined(THREAD_SANITIZER)
// Test that we can get OnCandidatesAllocationDone callback when all the ports
// are disabled.
TEST_F(PortAllocatorTest, TestDisableAllPorts) {
@ -513,8 +509,6 @@ TEST_F(PortAllocatorTest, TestGetAllPortsNoUdpSockets) {
EXPECT_TRUE(candidate_allocation_done_);
}
#endif // if !defined(THREAD_SANITIZER)
// Test that we don't crash or malfunction if we can't create UDP sockets or
// listen on TCP sockets. We still give out a local TCP address, since
// apparently this is needed for the remote side to accept our connection.