admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove stop method from VideoTrackSourceInterface.

Browse Source 
This method is no longer needed.

Follow-up on CL: https://codereview.webrtc.org/2306013002/

Review-Url: https://codereview.webrtc.org/2312603003
Cr-Commit-Position: refs/heads/master@{#14085}
This commit is contained in:
sakal 2016-09-06 02:25:08 -07:00 committed by Commit bot
parent c928453fd0
commit 859e86107d
5 changed files with 2 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
webrtc/api/androidvideotracksource.h
View File

@ -34,10 +34,6 @@ class AndroidVideoTrackSource : public Notifier<VideoTrackSourceInterface> {
jobject j_egl_context,
bool is_screencast = false);
// Not used on Android.
// TODO(sakal/magjed): Try to remove this from the interface.
void Stop() override { RTC_NOTREACHED(); };
bool is_screencast() const override { return is_screencast_; }
// Indicates that the encoder should denoise video before encoding it.

2
webrtc/api/mediastreaminterface.h
View File

@ -106,8 +106,6 @@ class VideoTrackSourceInterface
int input_height;
};
virtual void Stop() = 0;
// Indicates that parameters suitable for screencasts should be automatically
// applied to RtpSenders.
// TODO(perkj): Remove these once all known applications have moved to

4
webrtc/api/videocapturertracksource.h
View File

@ -57,8 +57,6 @@ class VideoCapturerTrackSource : public VideoTrackSource,
bool GetStats(Stats* stats) override;
void Stop() override;
protected:
VideoCapturerTrackSource(rtc::Thread* worker_thread,
cricket::VideoCapturer* capturer,
@ -67,6 +65,8 @@ class VideoCapturerTrackSource : public VideoTrackSource,
void Initialize(const webrtc::MediaConstraintsInterface* constraints);
private:
void Stop();
void OnStateChange(cricket::VideoCapturer* capturer,
cricket::CaptureState capture_state);

1
webrtc/api/videosourceproxy.h
View File

@ -23,7 +23,6 @@ namespace webrtc {
BEGIN_PROXY_MAP(VideoTrackSource)
PROXY_CONSTMETHOD0(SourceState, state)
PROXY_CONSTMETHOD0(bool, remote)
PROXY_METHOD0(void, Stop)
PROXY_CONSTMETHOD0(bool, is_screencast)
PROXY_CONSTMETHOD0(rtc::Optional<bool>, needs_denoising)
PROXY_METHOD1(bool, GetStats, Stats*)

2
webrtc/api/videotracksource.h
View File

@ -33,8 +33,6 @@ class VideoTrackSource : public Notifier<VideoTrackSourceInterface> {
SourceState state() const override { return state_; }
bool remote() const override { return remote_; }
void Stop() override{};
bool is_screencast() const override { return false; }
rtc::Optional<bool> needs_denoising() const override {
return rtc::Optional<bool>(); }