admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Disabling a couple flaky CallPerfTests on Mac.

Browse Source 
Specifically, KeepsHighBitrateWhenReconfiguringSender and
MinVideoAndAudioBitrate.

TBR=stefan@webrtc.org

Bug: webrtc:8878
Change-Id: I7c3f110dec199ffc4226b24fea404ee205932940
Reviewed-on: https://webrtc-review.googlesource.com/54620
Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22060}
This commit is contained in:
Taylor Brandstetter 2018-02-16 10:11:49 -08:00
parent ba6b503ae5
commit 85904f4ee8
1 changed files with 18 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
call/call_perf_tests.cc
View File

@ -647,7 +647,15 @@ TEST_F(CallPerfTest, NoPadWithoutMinTransmitBitrate) {
TestMinTransmitBitrate(false);
}
TEST_F(CallPerfTest, KeepsHighBitrateWhenReconfiguringSender) {
// TODO(bugs.webrtc.org/8878)
#if defined(WEBRTC_MAC)
#define MAYBE_KeepsHighBitrateWhenReconfiguringSender \
DISABLED_KeepsHighBitrateWhenReconfiguringSender
#else
#define MAYBE_KeepsHighBitrateWhenReconfiguringSender \
KeepsHighBitrateWhenReconfiguringSender
#endif
TEST_F(CallPerfTest, MAYBE_KeepsHighBitrateWhenReconfiguringSender) {
static const uint32_t kInitialBitrateKbps = 400;
static const uint32_t kReconfigureThresholdKbps = 600;
static const uint32_t kPermittedReconfiguredBitrateDiffKbps = 100;
@ -926,7 +934,15 @@ void CallPerfTest::TestMinAudioVideoBitrate(
RunBaseTest(&test);
}
TEST_F(CallPerfTest, MinVideoAndAudioBitrate) {
// TODO(bugs.webrtc.org/8878)
#if defined(WEBRTC_MAC)
#define MAYBE_MinVideoAndAudioBitrate \
DISABLED_MinVideoAndAudioBitrate
#else
#define MAYBE_MinVideoAndAudioBitrate \
MinVideoAndAudioBitrate
#endif
TEST_F(CallPerfTest, MAYBE_MinVideoAndAudioBitrate) {
TestMinAudioVideoBitrate(false, 110, 40, -10, 10000, 70000, 200000);
}
TEST_F(CallPerfTest, MinVideoAndAudioBitrateWStrategy) {