admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Do not compile frame_analyzer on component builds.

Browse Source 
No-Try: True
Bug: None
Change-Id: I8a7f62ee3a35c344c3a95c1b1b018dd07e1de00e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/284120
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38679}
This commit is contained in:
Mirko Bonadei 2022-11-18 13:25:21 +01:00 committed by WebRTC LUCI CQ
parent 63dda507f5
commit 858864dcb4
1 changed files with 40 additions and 39 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

41
rtc_tools/BUILD.gn
View File

@ -14,10 +14,7 @@ group("rtc_tools") {
# This target shall build all targets in tools/. # This target shall build all targets in tools/.
testonly = true testonly = true
deps = [ deps = [ ":video_file_reader" ]
":frame_analyzer",
":video_file_reader",
]
if (!build_with_chromium) { if (!build_with_chromium) {
deps += [ deps += [
":psnr_ssim_analyzer", ":psnr_ssim_analyzer",
@ -124,6 +121,24 @@ rtc_library("video_quality_analysis") {
absl_deps = [ "//third_party/abseil-cpp/absl/types:optional" ] absl_deps = [ "//third_party/abseil-cpp/absl/types:optional" ]
} }
# TODO(bugs.webrtc.org/11474): Enable this on win if needed. For now it
# is only required for Linux and Android.
if (!build_with_chromium && !build_with_mozilla && !is_win && !is_ios) {
action("frame_analyzer_host") {
script = "//tools_webrtc/executable_host_build.py"
outputs = [ "${root_out_dir}/frame_analyzer_host" ]
args = [
"--executable_name",
"frame_analyzer",
]
}
}
if (!is_component_build) {
# This target can be built from Chromium but it doesn't support
# is_component_build=true because it depends on WebRTC testonly code
# which is not part of //third_party/webrtc_overrides:webrtc_component.
# Abseil dependencies are not moved to the absl_deps field deliberately. # Abseil dependencies are not moved to the absl_deps field deliberately.
# If build_with_chromium is true, the absl_deps replaces the dependencies with # If build_with_chromium is true, the absl_deps replaces the dependencies with
# the "//third_party/abseil-cpp:absl" target. Which doesn't include absl/flags # the "//third_party/abseil-cpp:absl" target. Which doesn't include absl/flags
@ -158,20 +173,6 @@ rtc_executable("frame_analyzer") {
} }
} }
# TODO(bugs.webrtc.org/11474): Enable this on win if needed. For now it
# is only required for Linux and Android.
if (!build_with_chromium && !build_with_mozilla && !is_win && !is_ios) {
action("frame_analyzer_host") {
script = "//tools_webrtc/executable_host_build.py"
outputs = [ "${root_out_dir}/frame_analyzer_host" ]
args = [
"--executable_name",
"frame_analyzer",
]
}
}
if (!is_component_build) {
# This target can be built from Chromium but it doesn't support # This target can be built from Chromium but it doesn't support
# is_component_build=true because it depends on WebRTC testonly code # is_component_build=true because it depends on WebRTC testonly code
# which is not part of //third_party/webrtc_overrides:webrtc_component. # which is not part of //third_party/webrtc_overrides:webrtc_component.
@ -180,7 +181,7 @@ if (!is_component_build) {
# If build_with_chromium is true, the absl_deps replaces the dependencies with # If build_with_chromium is true, the absl_deps replaces the dependencies with
# the "//third_party/abseil-cpp:absl" target. Which doesn't include absl/flags # the "//third_party/abseil-cpp:absl" target. Which doesn't include absl/flags
# (and some others) because they cannot be used in Chromiums. Special exception # (and some others) because they cannot be used in Chromiums. Special exception
# for the "frame_analyzer" target in "third_party/abseil-cpp/absl.gni" allows # for the "rtp_generator" target in "third_party/abseil-cpp/absl.gni" allows
# it to be build in chromium. # it to be build in chromium.
rtc_executable("rtp_generator") { rtc_executable("rtp_generator") {
visibility = [ "*" ] visibility = [ "*" ]
@ -241,7 +242,7 @@ if (!is_component_build) {
# If build_with_chromium is true, the absl_deps replaces the dependencies with # If build_with_chromium is true, the absl_deps replaces the dependencies with
# the "//third_party/abseil-cpp:absl" target. Which doesn't include absl/flags # the "//third_party/abseil-cpp:absl" target. Which doesn't include absl/flags
# (and some others) because they cannot be used in Chromiums. Special exception # (and some others) because they cannot be used in Chromiums. Special exception
# for the "frame_analyzer" target in "third_party/abseil-cpp/absl.gni" allows # for the "video_replay" target in "third_party/abseil-cpp/absl.gni" allows
# it to be build in chromium. # it to be build in chromium.
rtc_executable("video_replay") { rtc_executable("video_replay") {
visibility = [ "*" ] visibility = [ "*" ]