admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

SUCCEEDED macro is misused

Browse Source 
SUCCEEDED macro is designed for HRESULT instead of BOOL.
This change exposes my lack of knowledge of native Windows APIs. :(

BUG=https://bugs.chromium.org/p/chromium/issues/detail?id=647067

Review-Url: https://codereview.webrtc.org/2440563003
Cr-Commit-Position: refs/heads/master@{#14716}
This commit is contained in:
zijiehe 2016-10-20 17:00:37 -07:00 committed by Commit bot
parent bdb8df895a
commit 84fbf9ee38
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
webrtc/modules/desktop_capture/screen_drawer_win.cc
View File

@ -174,8 +174,8 @@ void ScreenDrawerWin::DrawDot(DesktopVector vect, RgbaColor color) {
}
void ScreenDrawerWin::BringToFront() {
if (SUCCEEDED(SetWindowPos(
window_, HWND_TOPMOST, 0, 0, 0, 0, SWP_NOMOVE | SWP_NOSIZE))) {
if (SetWindowPos(window_, HWND_TOPMOST, 0, 0, 0, 0,
SWP_NOMOVE | SWP_NOSIZE) != FALSE) {
return;
}