diff --git a/webrtc/base/BUILD.gn b/webrtc/base/BUILD.gn index 115f31a042..73382f19fa 100644 --- a/webrtc/base/BUILD.gn +++ b/webrtc/base/BUILD.gn @@ -12,6 +12,12 @@ import("../build/webrtc.gni") import("//build_overrides/webrtc.gni") +config("rtc_base_approved_all_dependent_config") { + if (is_mac && !build_with_chromium) { + libs = [ "Foundation.framework" ] # needed for logging_mac.mm + } +} + config("rtc_base_config") { include_dirs = [ "//third_party/jsoncpp/overrides/include", @@ -94,6 +100,7 @@ static_library("rtc_base_approved") { deps = [] configs += [ "..:common_config" ] public_configs = [ "..:common_inherited_config" ] + all_dependent_configs = [ ":rtc_base_approved_all_dependent_config" ] sources = [ "array_view.h", diff --git a/webrtc/tools/BUILD.gn b/webrtc/tools/BUILD.gn index c71d31d34b..603e99944c 100644 --- a/webrtc/tools/BUILD.gn +++ b/webrtc/tools/BUILD.gn @@ -47,9 +47,6 @@ executable("frame_analyzer") { ":command_line_parser", ":video_quality_analysis", ] - if (is_mac) { - libs = [ "Foundation.framework" ] - } } executable("rgba_to_i420_converter") { @@ -62,9 +59,6 @@ executable("rgba_to_i420_converter") { ":command_line_parser", "../common_video", ] - if (is_mac) { - libs = [ "Foundation.framework" ] - } } # TODO(kjellander): Convert all of tools.gyp into GN here. @@ -85,8 +79,5 @@ if (!build_with_chromium) { "../test:test_support_main", "//testing/gtest", ] - if (is_mac) { - libs = [ "Foundation.framework" ] - } } }