admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Reduce logging frequency in bwe simulations.

Browse Source 
BUG=webrtc:5962
NOTRY=true

Review-Url: https://codereview.webrtc.org/2030903002
Cr-Commit-Position: refs/heads/master@{#13025}
This commit is contained in:
stefan 2016-06-03 00:20:34 -07:00 committed by Commit bot
parent 8f4c77fea1
commit 846b2d9c5c
2 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.cc
View File

@ -28,7 +28,8 @@ FullBweSender::FullBweSender(int kbps, BitrateObserver* observer, Clock* clock)
clock_(clock),
send_time_history_(clock_, 10000),
has_received_ack_(false),
last_acked_seq_num_(0) {
last_acked_seq_num_(0),
last_log_time_ms_(0) {
assert(kbps >= kMinBitrateKbps);
assert(kbps <= kMaxBitrateKbps);
bitrate_controller_->SetStartBitrate(1000 * kbps);
@ -52,7 +53,11 @@ void FullBweSender::GiveFeedback(const FeedbackPacket& feedback) {
std::vector<PacketInfo> packet_feedback_vector(fb.packet_feedback_vector());
for (PacketInfo& packet_info : packet_feedback_vector) {
if (!send_time_history_.GetInfo(&packet_info, true)) {
LOG(LS_WARNING) << "Ack arrived too late.";
int64_t now_ms = clock_->TimeInMilliseconds();
if (now_ms - last_log_time_ms_ > 5000) {
LOG(LS_WARNING) << "Ack arrived too late.";
last_log_time_ms_ = now_ms;
}
}
}

1
webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.h
View File

@ -45,6 +45,7 @@ class FullBweSender : public BweSender, public RemoteBitrateObserver {
SendTimeHistory send_time_history_;
bool has_received_ack_;
uint16_t last_acked_seq_num_;
int64_t last_log_time_ms_;
RTC_DISALLOW_IMPLICIT_CONSTRUCTORS(FullBweSender);
};