From 8432e1f4b84f79c4eea3a0820f4c4a83c267ef80 Mon Sep 17 00:00:00 2001 From: marpan Date: Wed, 13 Jan 2016 08:35:44 -0800 Subject: [PATCH] Re-enable tests that failed under Linux_Msan. Fixed in latest libvpx roll. Keep EndToEndTest.TransportSeqNumOnAudioAndVideo disabled on Win_DrMemory for now as it seems to time-out/too slow. TBR=stefan@webrtc.org, kjellander@webrtc.org BUG=webrtc:5402 NOTRY=True Review URL: https://codereview.webrtc.org/1577313003 Cr-Commit-Position: refs/heads/master@{#11240} --- .../gtest_exclude/video_engine_tests.gtest-drmemory_win32.txt | 1 - webrtc/video/video_send_stream_tests.cc | 4 ---- 2 files changed, 5 deletions(-) diff --git a/tools/valgrind-webrtc/gtest_exclude/video_engine_tests.gtest-drmemory_win32.txt b/tools/valgrind-webrtc/gtest_exclude/video_engine_tests.gtest-drmemory_win32.txt index 3582a48f52..c4d953aef3 100644 --- a/tools/valgrind-webrtc/gtest_exclude/video_engine_tests.gtest-drmemory_win32.txt +++ b/tools/valgrind-webrtc/gtest_exclude/video_engine_tests.gtest-drmemory_win32.txt @@ -10,7 +10,6 @@ EndToEndTest.RestartingSendStreamPreservesRtpStatesWithRtx EndToEndTest.SendsAndReceivesH264 EndToEndTest.SendsAndReceivesVP9 EndToEndTest.TransportFeedbackNotConfigured -# https://bugs.chromium.org/p/webrtc/issues/detail?id=5402 EndToEndTest.TransportSeqNumOnAudioAndVideo VideoSendStreamTest.CanReconfigureToUseStartBitrateAbovePreviousMax VideoSendStreamTest.ReconfigureBitratesSetsEncoderBitratesCorrectly diff --git a/webrtc/video/video_send_stream_tests.cc b/webrtc/video/video_send_stream_tests.cc index efdee1906f..4cf92748a8 100644 --- a/webrtc/video/video_send_stream_tests.cc +++ b/webrtc/video/video_send_stream_tests.cc @@ -2146,9 +2146,6 @@ TEST_F(VideoSendStreamTest, Vp9NonFlexMode_1Tl2SLayers) { TestVp9NonFlexMode(kNumTemporalLayers, kNumSpatialLayers); } -#if !defined(MEMORY_SANITIZER) -// Fails under MemorySanitizer: -// See https://code.google.com/p/webrtc/issues/detail?id=5402. TEST_F(VideoSendStreamTest, Vp9NonFlexMode_2Tl2SLayers) { const uint8_t kNumTemporalLayers = 2; const uint8_t kNumSpatialLayers = 2; @@ -2160,7 +2157,6 @@ TEST_F(VideoSendStreamTest, Vp9NonFlexMode_3Tl2SLayers) { const uint8_t kNumSpatialLayers = 2; TestVp9NonFlexMode(kNumTemporalLayers, kNumSpatialLayers); } -#endif void VideoSendStreamTest::TestVp9NonFlexMode(uint8_t num_temporal_layers, uint8_t num_spatial_layers) {