admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Delete deprecated RtpRtcp::CreateRtpRtcp factory

Browse Source 
Bug: None
Change-Id: I2ace74c380b89d300a6d0e7cca4766147f33cb1d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/149821
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28890}
This commit is contained in:
Danil Chapovalov 2019-08-19 10:35:21 +02:00 committed by Commit Bot
parent 3c7abdc4bd
commit 83773b555c
2 changed files with 0 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
modules/rtp_rtcp/include/rtp_rtcp.h
View File

@ -133,9 +133,6 @@ class RtpRtcp : public Module, public RtcpFeedbackSenderInterface {
// Creates an RTP/RTCP module object using provided |configuration|.
static std::unique_ptr<RtpRtcp> Create(const Configuration& configuration);
// Prefer factory function just above.
RTC_DEPRECATED
static RtpRtcp* CreateRtpRtcp(const RtpRtcp::Configuration& configuration);
// **************************************************************************
// Receiver functions

12
modules/rtp_rtcp/source/rtp_rtcp_impl.cc
View File

@ -46,18 +46,6 @@ std::unique_ptr<RtpRtcp> RtpRtcp::Create(const Configuration& configuration) {
return absl::make_unique<ModuleRtpRtcpImpl>(configuration);
}
RtpRtcp* RtpRtcp::CreateRtpRtcp(const RtpRtcp::Configuration& configuration) {
if (configuration.clock) {
return new ModuleRtpRtcpImpl(configuration);
} else {
// No clock implementation provided, use default clock.
RtpRtcp::Configuration configuration_copy;
memcpy(&configuration_copy, &configuration, sizeof(RtpRtcp::Configuration));
configuration_copy.clock = Clock::GetRealTimeClock();
return new ModuleRtpRtcpImpl(configuration_copy);
}
}
ModuleRtpRtcpImpl::ModuleRtpRtcpImpl(const Configuration& configuration)
: rtcp_sender_(configuration),
rtcp_receiver_(configuration, this),