From 82eb3c430916be1c7350972d6f7ab51f07e3ad6c Mon Sep 17 00:00:00 2001 From: Elad Alon Date: Fri, 6 Oct 2017 11:34:15 +0200 Subject: [PATCH] Remove dead version of StartRtcEventLog MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit These versions of StartRtcEventLog() are not used. Bug: webrtc:8111 Change-Id: I1fb543a908decff203b13f8358598f75d875c111 Reviewed-on: https://webrtc-review.googlesource.com/6782 Commit-Queue: Elad Alon Reviewed-by: Björn Terelius Reviewed-by: Karl Wiberg Cr-Commit-Position: refs/heads/master@{#20191} --- api/peerconnectionfactoryproxy.h | 5 ----- api/peerconnectioninterface.h | 19 ------------------- pc/peerconnectionfactory.h | 9 --------- 3 files changed, 33 deletions(-) diff --git a/api/peerconnectionfactoryproxy.h b/api/peerconnectionfactoryproxy.h index 430bca525e..7601ed144e 100644 --- a/api/peerconnectionfactoryproxy.h +++ b/api/peerconnectionfactoryproxy.h @@ -66,11 +66,6 @@ BEGIN_SIGNALING_PROXY_MAP(PeerConnectionFactory) CreateAudioTrack, const std::string&, AudioSourceInterface*) PROXY_METHOD2(bool, StartAecDump, rtc::PlatformFile, int64_t) PROXY_METHOD0(void, StopAecDump) - // TODO(ivoc): Remove the StartRtcEventLog and StopRtcEventLog functions as - // soon as they are removed from PeerConnectionFactoryInterface. - PROXY_METHOD1(bool, StartRtcEventLog, rtc::PlatformFile) - PROXY_METHOD2(bool, StartRtcEventLog, rtc::PlatformFile, int64_t) - PROXY_METHOD0(void, StopRtcEventLog) END_PROXY_MAP() } // namespace webrtc diff --git a/api/peerconnectioninterface.h b/api/peerconnectioninterface.h index c138e9ea20..7291a8641c 100644 --- a/api/peerconnectioninterface.h +++ b/api/peerconnectioninterface.h @@ -1028,25 +1028,6 @@ class PeerConnectionFactoryInterface : public rtc::RefCountInterface { // Stops logging the AEC dump. virtual void StopAecDump() = 0; - // This function is deprecated and will be removed when Chrome is updated to - // use the equivalent function on PeerConnectionInterface. - // TODO(ivoc) Remove after Chrome is updated. - virtual bool StartRtcEventLog(rtc::PlatformFile file, - int64_t max_size_bytes) { - return false; - } - // This function is deprecated and will be removed when Chrome is updated to - // use the equivalent function on PeerConnectionInterface. - // TODO(ivoc) Remove after Chrome is updated. - virtual bool StartRtcEventLog(rtc::PlatformFile file) { - return false; - } - - // This function is deprecated and will be removed when Chrome is updated to - // use the equivalent function on PeerConnectionInterface. - // TODO(ivoc) Remove after Chrome is updated. - virtual void StopRtcEventLog() {} - protected: // Dtor and ctor protected as objects shouldn't be created or deleted via // this interface. diff --git a/pc/peerconnectionfactory.h b/pc/peerconnectionfactory.h index 7066e2b6ab..7d71a69bd6 100644 --- a/pc/peerconnectionfactory.h +++ b/pc/peerconnectionfactory.h @@ -85,15 +85,6 @@ class PeerConnectionFactory : public PeerConnectionFactoryInterface { bool StartAecDump(rtc::PlatformFile file, int64_t max_size_bytes) override; void StopAecDump() override; - // TODO(ivoc) Remove after Chrome is updated. - bool StartRtcEventLog(rtc::PlatformFile file) override { return false; } - // TODO(ivoc) Remove after Chrome is updated. - bool StartRtcEventLog(rtc::PlatformFile file, - int64_t max_size_bytes) override { - return false; - } - // TODO(ivoc) Remove after Chrome is updated. - void StopRtcEventLog() override {} virtual cricket::TransportController* CreateTransportController( cricket::PortAllocator* port_allocator,