Fix pylint presubmit errors and warnings from untouched modules.
BUG=None Change-Id: I619dab14875e19477beb8bfb566ed1f34009c025 Reviewed-on: https://webrtc-review.googlesource.com/85960 Reviewed-by: Oleh Prypin <oprypin@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23754}
This commit is contained in:
parent
d9711098b0
commit
81f5197512
@ -105,7 +105,7 @@ def _ConfigurationAndScores(data_frame, params,
|
||||
else:
|
||||
result['params'][param] = config_json['-' + param]
|
||||
|
||||
current_param_combination = param_combination( # pylint: disable=star-args
|
||||
current_param_combination = param_combination(
|
||||
**config_optimize_params)
|
||||
results[current_param_combination].append(result)
|
||||
return results
|
||||
|
||||
@ -181,7 +181,6 @@ class AudioAnnotationsExtractor(object):
|
||||
ext_kwargs = {'extvad_conf-' + ext_vad:
|
||||
self._external_vads[ext_vad].GetVadOutput()
|
||||
for ext_vad in self._external_vads}
|
||||
# pylint: disable=star-args
|
||||
np.savez_compressed(
|
||||
file=os.path.join(
|
||||
output_path,
|
||||
|
||||
@ -103,9 +103,9 @@ def _RunNinja(output_directory, args):
|
||||
|
||||
def _EncodeForGN(value):
|
||||
"""Encodes value as a GN literal."""
|
||||
if type(value) is str:
|
||||
if isinstance(value, str):
|
||||
return '"' + value + '"'
|
||||
elif type(value) is bool:
|
||||
elif isinstance(value, bool):
|
||||
return repr(value).lower()
|
||||
else:
|
||||
return repr(value)
|
||||
|
||||
@ -90,7 +90,7 @@ def RunCommand(command, working_dir=None, ignore_exit_code=False,
|
||||
logging.debug('CMD: %s CWD: %s', ' '.join(command), working_dir)
|
||||
env = os.environ.copy()
|
||||
if extra_env:
|
||||
assert all(type(value) == str for value in extra_env.values())
|
||||
assert all(isinstance(value, str) for value in extra_env.values())
|
||||
logging.debug('extra env: %s', extra_env)
|
||||
env.update(extra_env)
|
||||
p = subprocess.Popen(command,
|
||||
|
||||
@ -124,7 +124,7 @@ def _RunCommand(command, working_dir=None, ignore_exit_code=False,
|
||||
logging.debug('CMD: %s CWD: %s', ' '.join(command), working_dir)
|
||||
env = os.environ.copy()
|
||||
if extra_env:
|
||||
assert all(type(value) == str for value in extra_env.values())
|
||||
assert all(isinstance(value, str) for value in extra_env.values())
|
||||
logging.debug('extra env: %s', extra_env)
|
||||
env.update(extra_env)
|
||||
p = subprocess.Popen(command,
|
||||
|
||||
@ -114,7 +114,6 @@ def GetHeadersInBuildGnFileSources(file_content, target_abs_path):
|
||||
source_file = source_file_match.group('source_file')
|
||||
if source_file.endswith('.h'):
|
||||
source_file_tokens = string.split(source_file, '/')
|
||||
# pylint: disable=star-args
|
||||
headers_in_sources.add(os.path.join(target_abs_path,
|
||||
*source_file_tokens))
|
||||
return headers_in_sources
|
||||
|
||||
Loading…
x
Reference in New Issue
Block a user