admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix pylint presubmit errors and warnings from untouched modules.

Browse Source 
BUG=None

Change-Id: I619dab14875e19477beb8bfb566ed1f34009c025
Reviewed-on: https://webrtc-review.googlesource.com/85960
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23754}
This commit is contained in:
Artem Titov 2018-06-27 10:31:23 +02:00 committed by Commit Bot
parent d9711098b0
commit 81f5197512
6 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
modules/audio_processing/test/py_quality_assessment/apm_quality_assessment_optimize.py
View File

@ -105,7 +105,7 @@ def _ConfigurationAndScores(data_frame, params,
else: else:
result['params'][param] = config_json['-' + param] result['params'][param] = config_json['-' + param]
current_param_combination = param_combination( # pylint: disable=star-args current_param_combination = param_combination(
**config_optimize_params) **config_optimize_params)
results[current_param_combination].append(result) results[current_param_combination].append(result)
return results return results

1
modules/audio_processing/test/py_quality_assessment/quality_assessment/annotations.py
View File

@ -181,7 +181,6 @@ class AudioAnnotationsExtractor(object):
ext_kwargs = {'extvad_conf-' + ext_vad: ext_kwargs = {'extvad_conf-' + ext_vad:
self._external_vads[ext_vad].GetVadOutput() self._external_vads[ext_vad].GetVadOutput()
for ext_vad in self._external_vads} for ext_vad in self._external_vads}
# pylint: disable=star-args
np.savez_compressed( np.savez_compressed(
file=os.path.join( file=os.path.join(
output_path, output_path,

4
tools_webrtc/android/build_aar.py
View File

@ -103,9 +103,9 @@ def _RunNinja(output_directory, args):
def _EncodeForGN(value): def _EncodeForGN(value):
"""Encodes value as a GN literal.""" """Encodes value as a GN literal."""
if type(value) is str: if isinstance(value, str):
return '"' + value + '"' return '"' + value + '"'
elif type(value) is bool: elif isinstance(value, bool):
return repr(value).lower() return repr(value).lower()
else: else:
return repr(value) return repr(value)

2
tools_webrtc/autoroller/checkin_chromium_dep.py
View File

@ -90,7 +90,7 @@ def RunCommand(command, working_dir=None, ignore_exit_code=False,
logging.debug('CMD: %s CWD: %s', ' '.join(command), working_dir) logging.debug('CMD: %s CWD: %s', ' '.join(command), working_dir)
env = os.environ.copy() env = os.environ.copy()
if extra_env: if extra_env:
assert all(type(value) == str for value in extra_env.values()) assert all(isinstance(value, str) for value in extra_env.values())
logging.debug('extra env: %s', extra_env) logging.debug('extra env: %s', extra_env)
env.update(extra_env) env.update(extra_env)
p = subprocess.Popen(command, p = subprocess.Popen(command,

2
tools_webrtc/autoroller/roll_deps.py
View File

@ -124,7 +124,7 @@ def _RunCommand(command, working_dir=None, ignore_exit_code=False,
logging.debug('CMD: %s CWD: %s', ' '.join(command), working_dir) logging.debug('CMD: %s CWD: %s', ' '.join(command), working_dir)
env = os.environ.copy() env = os.environ.copy()
if extra_env: if extra_env:
assert all(type(value) == str for value in extra_env.values()) assert all(isinstance(value, str) for value in extra_env.values())
logging.debug('extra env: %s', extra_env) logging.debug('extra env: %s', extra_env)
env.update(extra_env) env.update(extra_env)
p = subprocess.Popen(command, p = subprocess.Popen(command,

1
tools_webrtc/presubmit_checks_lib/check_orphan_headers.py
View File

@ -114,7 +114,6 @@ def GetHeadersInBuildGnFileSources(file_content, target_abs_path):
source_file = source_file_match.group('source_file') source_file = source_file_match.group('source_file')
if source_file.endswith('.h'): if source_file.endswith('.h'):
source_file_tokens = string.split(source_file, '/') source_file_tokens = string.split(source_file, '/')
# pylint: disable=star-args
headers_in_sources.add(os.path.join(target_abs_path, headers_in_sources.add(os.path.join(target_abs_path,
*source_file_tokens)) *source_file_tokens))
return headers_in_sources return headers_in_sources