From 81c79f51aa842e0c8254ebd4e91dfb0cea7c181e Mon Sep 17 00:00:00 2001 From: mbonadei Date: Tue, 25 Apr 2017 23:42:15 -0700 Subject: [PATCH] Creating webrtc:video_stream_api This target keeps track of .h the files under webrtc/ that are not part of any target. If a .h file is not part of a target the 'gn check' utility is not able to spot if a target is missing a dependency because even if it parses '#include' directives it is not able to find a target that contains these headers. BUG=webrtc:7512 NOTRY=True Review-Url: https://codereview.webrtc.org/2841873002 Cr-Commit-Position: refs/heads/master@{#17874} --- webrtc/BUILD.gn | 7 +++++++ webrtc/call/BUILD.gn | 1 + webrtc/logging/BUILD.gn | 2 ++ webrtc/media/BUILD.gn | 1 + webrtc/modules/video_coding/BUILD.gn | 1 + webrtc/tools/BUILD.gn | 1 + webrtc/video/BUILD.gn | 2 ++ 7 files changed, 15 insertions(+) diff --git a/webrtc/BUILD.gn b/webrtc/BUILD.gn index bde2b86ae1..7649f46b8a 100644 --- a/webrtc/BUILD.gn +++ b/webrtc/BUILD.gn @@ -224,6 +224,13 @@ config("common_objc") { libs = [ "Foundation.framework" ] } +rtc_source_set("video_stream_api") { + sources = [ + "video_receive_stream.h", + "video_send_stream.h", + ] +} + if (!build_with_chromium) { # Target to build all the WebRTC production code. rtc_static_library("webrtc") { diff --git a/webrtc/call/BUILD.gn b/webrtc/call/BUILD.gn index 9cc3c18638..47847ccd1c 100644 --- a/webrtc/call/BUILD.gn +++ b/webrtc/call/BUILD.gn @@ -21,6 +21,7 @@ rtc_source_set("call_interfaces") { "syncable.h", ] deps = [ + "..:video_stream_api", "..:webrtc_common", "../api:audio_mixer_api", "../api:libjingle_peerconnection_api", diff --git a/webrtc/logging/BUILD.gn b/webrtc/logging/BUILD.gn index 6fcab59435..6032ba616f 100644 --- a/webrtc/logging/BUILD.gn +++ b/webrtc/logging/BUILD.gn @@ -27,6 +27,7 @@ rtc_source_set("rtc_event_log_api") { "rtc_event_log/rtc_event_log.h", ] deps = [ + "..:video_stream_api", "../base:rtc_base_approved", "../call:call_interfaces", ] @@ -94,6 +95,7 @@ if (rtc_enable_protobuf) { suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] } deps = [ + "..:video_stream_api", "../base:protobuf_utils", "../base:rtc_base_approved", ] diff --git a/webrtc/media/BUILD.gn b/webrtc/media/BUILD.gn index b1f768c52e..b6529bfe34 100644 --- a/webrtc/media/BUILD.gn +++ b/webrtc/media/BUILD.gn @@ -267,6 +267,7 @@ if (rtc_include_tests) { include_dirs = [] public_deps = [] deps = [ + "..:video_stream_api", "../modules/audio_coding:rent_a_codec", "../modules/audio_processing:audio_processing", "../p2p:rtc_p2p", diff --git a/webrtc/modules/video_coding/BUILD.gn b/webrtc/modules/video_coding/BUILD.gn index 821e3960cd..bafc8bae07 100644 --- a/webrtc/modules/video_coding/BUILD.gn +++ b/webrtc/modules/video_coding/BUILD.gn @@ -94,6 +94,7 @@ rtc_static_library("video_coding") { ":webrtc_i420", ":webrtc_vp8", ":webrtc_vp9", + "../..:video_stream_api", "../..:webrtc_common", "../../base:rtc_base", "../../base:rtc_base_approved", diff --git a/webrtc/tools/BUILD.gn b/webrtc/tools/BUILD.gn index 05b7adbf79..be3296d1ff 100644 --- a/webrtc/tools/BUILD.gn +++ b/webrtc/tools/BUILD.gn @@ -205,6 +205,7 @@ if (rtc_enable_protobuf) { } defines = [ "ENABLE_RTC_EVENT_LOG" ] deps = [ + "..:video_stream_api", "../base:rtc_base_approved", "../call:call_interfaces", "../logging:rtc_event_log_impl", diff --git a/webrtc/video/BUILD.gn b/webrtc/video/BUILD.gn index 20b5d109bd..76f6ece715 100644 --- a/webrtc/video/BUILD.gn +++ b/webrtc/video/BUILD.gn @@ -54,6 +54,7 @@ rtc_static_library("video") { } deps = [ + "..:video_stream_api", "..:webrtc_common", "../api:transport_api", "../api/video_codecs:video_codecs_api", @@ -249,6 +250,7 @@ if (rtc_include_tests) { ] deps = [ ":video", + "..:video_stream_api", "../api:video_frame_api", "../api/video_codecs:video_codecs_api", "../base:rtc_base_approved",