admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Stop using public_deps in logging/.

Browse Source 
Bug: webrtc:8603
Change-Id: Id0df997620a27e47067e4b21e4e8db16aec90640
No-Try: True
Reviewed-on: https://webrtc-review.googlesource.com/30940
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21228}
This commit is contained in:
Mirko Bonadei 2017-12-12 12:46:13 +01:00 committed by Commit Bot
parent 9060eb1528
commit 818d910392
3 changed files with 18 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
logging/BUILD.gn
View File

@ -14,11 +14,11 @@ if (is_android) {
}
group("logging") {
public_deps = [
deps = [
":rtc_event_log_impl",
]
if (rtc_enable_protobuf) {
public_deps += [ ":rtc_event_log_parser" ]
deps += [ ":rtc_event_log_parser" ]
}
}
@ -139,13 +139,17 @@ if (rtc_enable_protobuf) {
"rtc_event_log/rtc_event_log_parser.h",
]
public_deps = [
deps = [
":rtc_event_log_api",
":rtc_event_log_proto",
"..:webrtc_common",
"../call:video_stream_api",
"../modules/audio_coding:audio_network_adaptor",
"../modules/remote_bitrate_estimator:remote_bitrate_estimator",
"../modules/rtp_rtcp",
"../modules/rtp_rtcp:rtp_rtcp_format",
"../rtc_base:protobuf_utils",
"../rtc_base:rtc_base_approved",
"../system_wrappers",
]
@ -153,12 +157,6 @@ if (rtc_enable_protobuf) {
# Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
}
deps = [
"../call:video_stream_api",
"../modules/rtp_rtcp:rtp_rtcp_format",
"../rtc_base:protobuf_utils",
"../rtc_base:rtc_base_approved",
]
}
if (rtc_include_tests) {
@ -177,8 +175,10 @@ if (rtc_enable_protobuf) {
"rtc_event_log/rtc_event_log_unittest_helper.h",
]
deps = [
":rtc_event_log_api",
":rtc_event_log_impl",
":rtc_event_log_parser",
":rtc_event_log_proto",
"../api:libjingle_peerconnection_api",
"../call",
"../call:call_interfaces",
@ -206,7 +206,9 @@ if (rtc_enable_protobuf) {
":rtc_event_log_api",
":rtc_event_log_impl",
":rtc_event_log_parser",
"../modules/rtp_rtcp",
"../modules/rtp_rtcp:rtp_rtcp_format",
"../rtc_base:protobuf_utils",
"../rtc_base:rtc_base_approved",
"../system_wrappers:field_trial_default",
"../system_wrappers:metrics_default",
@ -228,8 +230,10 @@ if (rtc_enable_protobuf) {
":rtc_event_log_api",
":rtc_event_log_impl",
":rtc_event_log_parser",
"../:webrtc_common",
"../call:video_stream_api",
"../modules/rtp_rtcp:rtp_rtcp_format",
"../rtc_base:protobuf_utils",
"../rtc_base:rtc_base_approved",
# TODO(kwiberg): Remove this dependency.

1
modules/audio_coding/BUILD.gn
View File

@ -1194,6 +1194,7 @@ if (rtc_enable_protobuf) {
":neteq_tools_minimal",
"../../logging:rtc_event_log_parser",
"../../rtc_base:rtc_base_approved",
"../rtp_rtcp",
"../rtp_rtcp:rtp_rtcp_format",
]
public_deps = [

4
rtc_tools/BUILD.gn
View File

@ -223,12 +223,15 @@ if (!build_with_chromium) {
defines = [ "ENABLE_RTC_EVENT_LOG" ]
deps = [
":chart_proto",
"../:webrtc_common",
"../call:call_interfaces",
"../call:video_stream_api",
"../logging:rtc_event_log_api",
"../logging:rtc_event_log_impl",
"../logging:rtc_event_log_parser",
"../modules:module_api",
"../modules/audio_coding:ana_debug_dump_proto",
"../modules/audio_coding:audio_network_adaptor",
"../modules/audio_coding:neteq_tools",
"../modules/rtp_rtcp:rtp_rtcp_format",
"../rtc_base:rtc_base_approved",
@ -263,6 +266,7 @@ if (rtc_include_tests) {
deps = [
":event_log_visualizer_utils",
"../logging:rtc_event_log_parser",
"../rtc_base:protobuf_utils",
"../rtc_base:rtc_base_approved",
"../test:field_trial",
"../test:test_support",