From 817544411185b2220318360e1b2d314e1055f630 Mon Sep 17 00:00:00 2001 From: Ranveer Aggarwal Date: Wed, 19 Feb 2025 09:39:27 +0100 Subject: [PATCH] Remove instances of j.u.Optional from EGLRenderer MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit j.u.Optional isn't available for sdk version <24 and our minsdk is 21. Bug: webrtc:351858995 Change-Id: Iadf50a96fc5462d16b53857116fab271cecc8c3c Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/374061 Reviewed-by: Sergey Silkin Auto-Submit: Ranveer Aggarwal‎ Reviewed-by: Zoé Lepaul Commit-Queue: Sergey Silkin Cr-Commit-Position: refs/heads/main@{#43935} --- sdk/android/api/org/webrtc/EglRenderer.java | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/sdk/android/api/org/webrtc/EglRenderer.java b/sdk/android/api/org/webrtc/EglRenderer.java index 04876981b2..f8bcd57b78 100644 --- a/sdk/android/api/org/webrtc/EglRenderer.java +++ b/sdk/android/api/org/webrtc/EglRenderer.java @@ -22,7 +22,6 @@ import java.nio.ByteBuffer; import java.text.DecimalFormat; import java.util.ArrayList; import java.util.Iterator; -import java.util.Optional; import java.util.UUID; import java.util.concurrent.CountDownLatch; import java.util.concurrent.TimeUnit; @@ -33,6 +32,7 @@ import java.util.concurrent.TimeUnit; */ public class EglRenderer implements VideoSink { private static final String TAG = "EglRenderer"; + private static final UUID EMPTY_UUID = new UUID(0L, 0L); // All zeros private static final long LOG_INTERVAL_SEC = 4; public interface FrameListener { void onFrame(Bitmap frame); } @@ -98,7 +98,7 @@ public class EglRenderer implements VideoSink { // An id to uniquely identify the renderer, used for when we're scheduling // frames for render. - private Optional id = Optional.empty(); + private UUID id = EMPTY_UUID; // `eglThread` is used for rendering, and is synchronized on `threadLock`. private final Object threadLock = new Object(); @@ -233,7 +233,7 @@ public class EglRenderer implements VideoSink { boolean usePresentationTimeStamp, boolean overwritePendingFrames) { if (overwritePendingFrames) { - id = Optional.of(UUID.randomUUID()); + id = UUID.randomUUID(); } init(eglThread, drawer, usePresentationTimeStamp); } @@ -661,10 +661,10 @@ public class EglRenderer implements VideoSink { renderSwapBufferTimeNs += (System.nanoTime() - swapBuffersStartTimeNs); } }; - if (id.isPresent()) { - eglThread.scheduleRenderUpdate(id.get(), renderUpdate); - } else { + if (id.equals(EMPTY_UUID)) { eglThread.scheduleRenderUpdate(renderUpdate); + } else { + eglThread.scheduleRenderUpdate(id, renderUpdate); } } }