admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Replace WebRTC-QuickPerfTest field trial with similar named dedicated test flag

Browse Source 
Bug: webrtc:7101
Change-Id: I4034f90fdd3456c1d09981142ad494ad150f7b94
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/322801
Reviewed-by: Jeremy Leconte <jleconte@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40901}
This commit is contained in:
Danil Chapovalov 2023-10-10 12:23:25 +02:00 committed by WebRTC LUCI CQ
parent 60362c144c
commit 8144935b78
5 changed files with 14 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
experiments/field_trials.py
View File

@ -700,9 +700,6 @@ POLICY_EXEMPT_FIELD_TRIALS: FrozenSet[FieldTrial] = frozenset([
FieldTrial('WebRTC-QpParsingKillSwitch',
'webrtc:12542',
date(2024, 4, 1)),
FieldTrial('WebRTC-QuickPerfTest',
'webrtc:7101',
INDEFINITE),
FieldTrial('WebRTC-RtcEventLogKillSwitch',
'webrtc:12084',
INDEFINITE),

2
infra/specs/mixins.pyl
View File

@ -220,7 +220,7 @@
'args': ['--nologs']
},
'quick-perf-tests': {
'args': ['--force_fieldtrials=WebRTC-QuickPerfTest/Enabled/', '--nologs']
'args': ['--webrtc_quick_perf_test', '--nologs']
},
'redfin': {
'swarming': {

2
infra/specs/mixins_webrtc.pyl
View File

@ -158,7 +158,7 @@
},
'quick-perf-tests': {
'args': [
'--force_fieldtrials=WebRTC-QuickPerfTest/Enabled/',
'--webrtc_quick_perf_test',
'--nologs',
],
},

24
infra/specs/tryserver.webrtc.json
View File

@ -431,7 +431,7 @@
},
{
"args": [
"--force_fieldtrials=WebRTC-QuickPerfTest/Enabled/",
"--webrtc_quick_perf_test",
"--nologs"
],
"merge": {
@ -908,7 +908,7 @@
},
{
"args": [
"--force_fieldtrials=WebRTC-QuickPerfTest/Enabled/",
"--webrtc_quick_perf_test",
"--nologs"
],
"merge": {
@ -1385,7 +1385,7 @@
},
{
"args": [
"--force_fieldtrials=WebRTC-QuickPerfTest/Enabled/",
"--webrtc_quick_perf_test",
"--nologs"
],
"merge": {
@ -1887,7 +1887,7 @@
},
{
"args": [
"--force_fieldtrials=WebRTC-QuickPerfTest/Enabled/",
"--webrtc_quick_perf_test",
"--nologs"
],
"merge": {
@ -5962,7 +5962,7 @@
},
{
"args": [
"--force_fieldtrials=WebRTC-QuickPerfTest/Enabled/",
"--webrtc_quick_perf_test",
"--nologs",
"--gtest_output=json:${ISOLATED_OUTDIR}/gtest_output.json"
],
@ -6041,7 +6041,7 @@
},
{
"args": [
"--force_fieldtrials=WebRTC-QuickPerfTest/Enabled/",
"--webrtc_quick_perf_test",
"--nologs",
"--gtest_output=json:${ISOLATED_OUTDIR}/gtest_output.json"
],
@ -7437,7 +7437,7 @@
},
{
"args": [
"--force_fieldtrials=WebRTC-QuickPerfTest/Enabled/",
"--webrtc_quick_perf_test",
"--nologs",
"--gtest_output=json:${ISOLATED_OUTDIR}/gtest_output.json"
],
@ -7512,7 +7512,7 @@
},
{
"args": [
"--force_fieldtrials=WebRTC-QuickPerfTest/Enabled/",
"--webrtc_quick_perf_test",
"--nologs",
"--gtest_output=json:${ISOLATED_OUTDIR}/gtest_output.json"
],
@ -10572,7 +10572,7 @@
},
{
"args": [
"--force_fieldtrials=WebRTC-QuickPerfTest/Enabled/",
"--webrtc_quick_perf_test",
"--nologs",
"--gtest_output=json:${ISOLATED_OUTDIR}/gtest_output.json"
],
@ -10647,7 +10647,7 @@
},
{
"args": [
"--force_fieldtrials=WebRTC-QuickPerfTest/Enabled/",
"--webrtc_quick_perf_test",
"--nologs",
"--gtest_output=json:${ISOLATED_OUTDIR}/gtest_output.json"
],
@ -12638,7 +12638,7 @@
},
{
"args": [
"--force_fieldtrials=WebRTC-QuickPerfTest/Enabled/",
"--webrtc_quick_perf_test",
"--nologs",
"--gtest_output=json:${ISOLATED_OUTDIR}/gtest_output.json"
],
@ -12713,7 +12713,7 @@
},
{
"args": [
"--force_fieldtrials=WebRTC-QuickPerfTest/Enabled/",
"--webrtc_quick_perf_test",
"--nologs",
"--gtest_output=json:${ISOLATED_OUTDIR}/gtest_output.json"
],

5
test/test_main_lib.cc
View File

@ -150,11 +150,6 @@ class TestMainImpl : public TestMain {
// outlive the application.
field_trials_ = absl::GetFlag(FLAGS_force_fieldtrials);
webrtc::field_trial::InitFieldTrialsFromString(field_trials_.c_str());
// TODO(bugs.webrtc.org/7101): Remove when all invocation would use
// webrtc_quick_perf_test flag directly instead of setting the field trial.
if (webrtc::field_trial::IsEnabled("WebRTC-QuickPerfTest")) {
absl::SetFlag(&FLAGS_webrtc_quick_perf_test, true);
}
webrtc::metrics::Enable();
#if defined(WEBRTC_WIN)