admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Move RtcEventLogOutput to api/

Browse Source 
Move RtcEventLogOutput into the API, so that we would be able to change StartRtcEventLog (in PeerConnectionInterface) to use it.

Bug: webrtc:8111
Change-Id: I1d70af792ec584d3f1a8eced1b66c38e4a360642
Reviewed-on: https://webrtc-review.googlesource.com/7220
Commit-Queue: Elad Alon <eladalon@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20189}
This commit is contained in:
Elad Alon 2017-10-06 13:07:32 +02:00 committed by Commit Bot
parent 4bece9a4f0
commit 8081073677
5 changed files with 13 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
api/BUILD.gn
View File

@ -134,6 +134,12 @@ rtc_source_set("libjingle_api_deprecated_headers") {
] ]
} }
rtc_source_set("libjingle_logging_api") {
sources = [
"rtceventlogoutput.h",
]
}
rtc_source_set("ortc_api") { rtc_source_set("ortc_api") {
check_includes = false # TODO(deadbeef): Remove (bugs.webrtc.org/6828) check_includes = false # TODO(deadbeef): Remove (bugs.webrtc.org/6828)
sources = [ sources = [

7
logging/rtc_event_log/output/rtc_event_log_output.h → api/rtceventlogoutput.h
View File

@ -8,13 +8,14 @@
* be found in the AUTHORS file in the root of the source tree. * be found in the AUTHORS file in the root of the source tree.
*/ */
#ifndef LOGGING_RTC_EVENT_LOG_OUTPUT_RTC_EVENT_LOG_OUTPUT_H_ #ifndef API_RTCEVENTLOGOUTPUT_H_
#define LOGGING_RTC_EVENT_LOG_OUTPUT_RTC_EVENT_LOG_OUTPUT_H_ #define API_RTCEVENTLOGOUTPUT_H_
#include <string> #include <string>
namespace webrtc { namespace webrtc {
// NOTE: This class is still under development and may change without notice.
class RtcEventLogOutput { class RtcEventLogOutput {
public: public:
virtual ~RtcEventLogOutput() = default; virtual ~RtcEventLogOutput() = default;
@ -35,4 +36,4 @@ class RtcEventLogOutput {
} // namespace webrtc } // namespace webrtc
#endif // LOGGING_RTC_EVENT_LOG_OUTPUT_RTC_EVENT_LOG_OUTPUT_H_ #endif // API_RTCEVENTLOGOUTPUT_H_

2
logging/BUILD.gn
View File

@ -59,7 +59,6 @@ rtc_source_set("rtc_event_log_api") {
"rtc_event_log/events/rtc_event_video_receive_stream_config.h", "rtc_event_log/events/rtc_event_video_receive_stream_config.h",
"rtc_event_log/events/rtc_event_video_send_stream_config.cc", "rtc_event_log/events/rtc_event_video_send_stream_config.cc",
"rtc_event_log/events/rtc_event_video_send_stream_config.h", "rtc_event_log/events/rtc_event_video_send_stream_config.h",
"rtc_event_log/output/rtc_event_log_output.h",
"rtc_event_log/output/rtc_event_log_output_file.cc", "rtc_event_log/output/rtc_event_log_output_file.cc",
"rtc_event_log/output/rtc_event_log_output_file.h", "rtc_event_log/output/rtc_event_log_output_file.h",
"rtc_event_log/rtc_event_log.h", "rtc_event_log/rtc_event_log.h",
@ -71,6 +70,7 @@ rtc_source_set("rtc_event_log_api") {
deps = [ deps = [
"..:webrtc_common", "..:webrtc_common",
"../api:array_view", "../api:array_view",
"../api:libjingle_logging_api",
"../api:libjingle_peerconnection_api", "../api:libjingle_peerconnection_api",
"../call:video_stream_api", "../call:video_stream_api",
"../modules/audio_coding:audio_network_adaptor_config", "../modules/audio_coding:audio_network_adaptor_config",

2
logging/rtc_event_log/output/rtc_event_log_output_file.h
View File

@ -16,7 +16,7 @@
#include <memory> #include <memory>
#include <string> #include <string>
#include "logging/rtc_event_log/output/rtc_event_log_output.h" #include "api/rtceventlogoutput.h"
#include "rtc_base/platform_file.h" // Can't neatly forward PlatformFile. #include "rtc_base/platform_file.h" // Can't neatly forward PlatformFile.
namespace webrtc { namespace webrtc {

2
logging/rtc_event_log/rtc_event_log.h
View File

@ -14,8 +14,8 @@
#include <memory> #include <memory>
#include <string> #include <string>
#include "api/rtceventlogoutput.h"
#include "logging/rtc_event_log/events/rtc_event.h" #include "logging/rtc_event_log/events/rtc_event.h"
#include "logging/rtc_event_log/output/rtc_event_log_output.h"
namespace webrtc { namespace webrtc {